Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create node-licence-checker.yml #199

Draft
wants to merge 36 commits into
base: master
Choose a base branch
from
Draft

Conversation

mschwrdtnr
Copy link
Member

@mschwrdtnr mschwrdtnr commented Aug 27, 2019

This action should check the licenses of new added dependencies. We can only allow MIT because the project is licensed under MIT.

Read more about the action under https://github.com/cds-snc/github-actions/tree/master/node-license-checker

@mschwrdtnr mschwrdtnr added the chore Work that does not create value for the user, but is needed for the project to work. label Aug 27, 2019
@mschwrdtnr
Copy link
Member Author

image

The check passes but there is probably a problem with this docker image

@mschwrdtnr mschwrdtnr requested a review from paule96 August 28, 2019 07:46
@mschwrdtnr mschwrdtnr added the help wanted Extra attention is needed label Aug 28, 2019
@mschwrdtnr
Copy link
Member Author

mschwrdtnr commented Aug 28, 2019

It looks like that the path is wrong. I tested several things local and didn't get a solution. Maybe @DanielHabenicht, @paule96 or @GentleJames you know how to solve this?
Link to Action - Maybe a problem with this line /home/runner/work/phonebook/phonebook ?

Other sources: License-Checker, Github-Action

@paule96
Copy link
Collaborator

paule96 commented Sep 1, 2019

maybe we should use WhiteSource

This do also more things. Check for security etc. And isn't only for node. So we are free in our tools and languages while development.

On the bad side:

You can't run it local. (for my current understanding.)

@paule96
Copy link
Collaborator

paule96 commented Sep 1, 2019

maybe @jandd know some good tools for this too. So we can maybe use something that we have experience with and can use it with many languages / tools.

@paule96 paule96 requested a review from jandd September 1, 2019 14:44
@mschwrdtnr mschwrdtnr added the BLOCKED This Issue is blocked. Have a look in the comments. label Sep 3, 2019
@mschwrdtnr
Copy link
Member Author

Can fix the problem by adding https://github.com/actions/checkout.

@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-199.demo-phonebook.me

@mmsgithub-ci
Copy link
Collaborator

Preview Environment ready at https://pr-199.demo-phonebook.me

@mschwrdtnr
Copy link
Member Author

mschwrdtnr commented Sep 26, 2019

I think that it is still not working because there is no folder with the modules and node-license-checker needs this probably...
So it should run npm install before

@mschwrdtnr
Copy link
Member Author

I would close this issue because of inactivity, everyone fine @T-Systems-MMS/phonebook-developers ?

@paule96
Copy link
Collaborator

paule96 commented Apr 8, 2020

I think it's okay for now. Let's talk about that in the next meeting

@DanielHabenicht DanielHabenicht marked this pull request as draft April 12, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLOCKED This Issue is blocked. Have a look in the comments. chore Work that does not create value for the user, but is needed for the project to work. help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants