Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No info dialog for IE users #445

Open
mschwrdtnr opened this issue Dec 10, 2019 · 11 comments · May be fixed by #519
Open

No info dialog for IE users #445

mschwrdtnr opened this issue Dec 10, 2019 · 11 comments · May be fixed by #519
Assignees
Labels
bug Something isn't working prio-3 Priority 3

Comments

@mschwrdtnr
Copy link
Member

mschwrdtnr commented Dec 10, 2019

Describe the bug:
If people open the phonebook in IE they will don't see anything.
image

Console:
image

To Reproduce:
Open demo-phonebook.me.

Expected behavior:
There should be an info that IE is not supported.
The dialog exists but don't show.

--> There is an option in IE where you can easy open the site in edge (
STRG+Shift+E). A button to open the site in another browser would be cool.

Additional context:
IE 11.864.17763.0

@mschwrdtnr mschwrdtnr added bug Something isn't working prio-3 Priority 3 labels Dec 10, 2019
@DanielHabenicht
Copy link
Collaborator

Possible solution: Display the dialog before using UrlSearchParams, or conditionally check if IE is used before accessing it.

@VanLampe VanLampe self-assigned this Jan 7, 2020
@DanielHabenicht
Copy link
Collaborator

We should display this dialog without the need to load angular, thus we can drop everything that we currently need to be compliant with IE.

@VanLampe
Copy link
Contributor

@DanielHabenicht so I will put clean JS code in an extra file, wich will be loaded before angular?

@DanielHabenicht
Copy link
Collaborator

Well you can also use the statement HTML feature of IE

https://docs.microsoft.com/en-us/previous-versions/windows/internet-explorer/ie-developer/compatibility/ms537512(v=vs.85)?redirectedfrom=MSDN

And add it to the index.html

@VanLampe
Copy link
Contributor

@DanielHabenicht
Copy link
Collaborator

Ok, dann einfach ein Javascript Snippet nutzen und am besten unten in der index.html anfügen.

@mschwrdtnr
Copy link
Member Author

accidentally closed @DanielHabenicht ?

@DanielHabenicht
Copy link
Collaborator

Seems so, the new GitHub app does not have colored buttons.

@mschwrdtnr
Copy link
Member Author

@FrankLambrette if you're implementing the feature maybe you can try to implement this, if it's easy..
"--> There is an option in IE where you can easy open the site in edge (
STRG+Shift+E). A button to open the site in another browser would be cool."

@VanLampe
Copy link
Contributor

VanLampe commented Mar 4, 2020

@DanielHabenicht @mschwrdtnr , after two month no i have some time to implement it. Just a question: how do I import a plain js script in the index.html? Angular Docu says I should put it in the angular.json scripts section. But we need to load the script before angular is loaded. If I try to import it via <script> I allways get a 404. Any ideas?

@DanielHabenicht
Copy link
Collaborator

Just include it directly in the index.html.

In the end, it does not have to be something fancy. A simple timeout/detection mechanism would do it aswell.

VanLampe added a commit that referenced this issue Mar 10, 2020
check for ie
links to open pb in other common browsers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio-3 Priority 3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants