Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: review sink reactions #81

Open
3 of 5 tasks
sulheim opened this issue May 23, 2019 · 0 comments
Open
3 of 5 tasks

feat: review sink reactions #81

sulheim opened this issue May 23, 2019 · 0 comments
Assignees

Comments

@sulheim
Copy link
Collaborator

sulheim commented May 23, 2019

Description of the issue:

There are currently 26 sink reactions in the model:

DM_2hymeph_c
DM_2mborn_c
DM_33biflav_c
DM_38biflav_c
DM_4crsol_c
DM_5drib_c
DM_ACT_c
DM_RED_c
DM_aacald_c
DM_acetone_c
DM_aconm_c
DM_ahop_c
DM_albflon_c
DM_amob_c
DM_dalua_c
DM_ectoine__L_c
DM_geosmin_c
DM_germicidinA_c
DM_germicidinB_c
DM_germicidinC_c
DM_germicidinD_c
DM_grmcrnd_c
DM_mmyA_c
DM_mmyB_c
DM_msh_c
DM_strprub_c

At least the sink reactions for red and act can be removed as there are transport and proper exchange reactions for these compounds. I suggest to do a full review to see

  • Which sink reactions can be removed immediately, and remove them
  • Search for transport reactions for the other compunds to see if some of the sink reactions can be replaced by transport and exchange reactions.

I hereby confirm that:

  • This problem persists in the master branch of the repository
  • A similar issue does not already exist
  • I've considered asking this first in the Gitter chat room
@sulheim sulheim self-assigned this Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant