Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify PR commits in contributor guidelines #147

Open
1 task
edkerk opened this issue Apr 5, 2021 · 0 comments
Open
1 task

doc: clarify PR commits in contributor guidelines #147

edkerk opened this issue Apr 5, 2021 · 0 comments

Comments

@edkerk
Copy link
Member

edkerk commented Apr 5, 2021

Applying squash or rebase merge on PRs from devel to master seems to result in the next PR between those branches still indicating the same commits as difference (+ any additional commits). To prevent this, in the contributor guidelines should be states that PRs from devel to master should always be a 'normal' merge commit. PRs from feature-branches to devel would preferably be rebase merges, to keep the git tree tidy. Note that there is no way to set this behaviour as default.

To do:

  • make changes in contributor guidelines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant