Skip to content
This repository has been archived by the owner on Sep 4, 2021. It is now read-only.

Unreliable requests (synths and tokens) on "Convert" page #334

Open
drptbl opened this issue Apr 12, 2021 · 4 comments
Open

Unreliable requests (synths and tokens) on "Convert" page #334

drptbl opened this issue Apr 12, 2021 · 4 comments
Labels
bug Something isn't working convert Issue related to "Convert" feature enhancement New feature or request

Comments

@drptbl
Copy link
Contributor

drptbl commented Apr 12, 2021

Description:
There are two unreliable requests on "Convert" page:
Screenshot 2021-04-12 at 22 22 20

"Convert" functionality doesn't work and "Select Token" modal is empty because of it.
Other than fixing this, part of this task should also be to improve error handling in such case on Kwenta to avoid such things (slippage -100%):
Screenshot 2021-04-12 at 22 45 14

It wasn't working for more than 1-2 hours when I was testing it.

Reproduction steps:

  1. Go to Kwenta "Convert" page (https://dev.kwenta.io/dashboard/convert)

Desktop (please complete the following information):

  • OS: macOS Big Sur 11.2.2
  • Browser: Chrome 89.0.4389.95
@drptbl drptbl added bug Something isn't working convert Issue related to "Convert" feature labels Apr 12, 2021
@drptbl drptbl changed the title Failing requests on "Convert" page Failing requests (synths and tokens) on "Convert" page Apr 12, 2021
@drptbl drptbl added the enhancement New feature or request label Apr 12, 2021
@evgenyboxer
Copy link
Contributor

evgenyboxer commented Apr 13, 2021

Hmm... @justinjmoses @clementbalestrat @andytcf any ideas why these requests sometimes fail?

@drptbl
Copy link
Contributor Author

drptbl commented Apr 14, 2021

synths.snx.eth.link request is also used on synthetix website now; "Synths" page:
https://synthetix-website-git-feat-synths-page-synthetixio.vercel.app/synths
so if this url fails to respond, not only convert feature won't be working but also "Synths" page.

@drptbl drptbl changed the title Failing requests (synths and tokens) on "Convert" page Unreliable requests (synths and tokens) on "Convert" page Apr 15, 2021
@jcmonte
Copy link
Contributor

jcmonte commented Apr 21, 2021

I think this was a one time event with ipfs/ens domains. I'm not able to replicate this, but now we use zapper token lists which aren't ipfs/ens so I think this issue can be closed

synths.snx.eth.link also has a fallback with synthetix-assets for this case

@jcmonte
Copy link
Contributor

jcmonte commented Apr 21, 2021

Also improved the -100% slippage handling in #347

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working convert Issue related to "Convert" feature enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants