From bb28d835992d28286ee3a4201ce2352f66578dc0 Mon Sep 17 00:00:00 2001 From: SymbolixAU Date: Thu, 28 Jun 2018 13:51:18 +1000 Subject: [PATCH] test and cran commits --- cran-comments.md | 4 +++- tests/testthat/test-sf_geojson.R | 5 ++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 4053707..dab4384 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,9 +1,11 @@ ## Release Summary * Updates v1.0 to v1.1 -* Removed dependencies on undeclared packages from unit tests, as per CRAN request - email "CRAN packages maintained by you" from Kurt Hornik, 2018-05-18 +* Removed dependencies on undeclared packages from unit tests, as per CRAN request - email "CRAN packages maintained by you" from Kurt Hornik, 2018-05-18 (https://cran.r-project.org/web/checks/check_results_geojsonsf.html) * Build Note - Fedora clang & gcc : installed size is 5.5mb / 6.8mb - The builds says the `libs` file is 3.7mb/5.0mb. I can't reduce this file size, all the compiled c++ headers and files are required. +* New gcc compiler warning : https://www.stats.ox.ac.uk/pub/bdr/gcc8/geojsonsf.out + - this warning references the souce C++ library `rapidjson`. There is an issue on their github page to fix this (https://github.com/Tencent/rapidjson/issues/1205). I will update this package once rapidjson has fixed this warning. ## Test Environments diff --git a/tests/testthat/test-sf_geojson.R b/tests/testthat/test-sf_geojson.R index 6a417d4..50df97d 100644 --- a/tests/testthat/test-sf_geojson.R +++ b/tests/testthat/test-sf_geojson.R @@ -153,12 +153,11 @@ test_that("errors are handled", { test_that("factors are strings", { - skip_on_cran() - skip_on_travis() - fgc <- '{"type":"Feature","geometry":{"type":"GeometryCollection","geometries":[{"type":"Point","coordinates":[100,0]},{"type":"LineString","coordinates":[[101,0],[102,1]]}]},"properties":{"prop0":"value0","prop1":"value1"}}' sf <- geojson_sf(fgc) sf$prop0 <- as.factor(sf$prop0) + geo <- sf_geojson(sf) + expect_true(grepl("value0", geo)) })