Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create build-android.sh and update instructions #8

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

AndrewSB
Copy link
Member

@AndrewSB AndrewSB commented Mar 3, 2018

Closes #5.

@lanza this is ready for you

zhuowei and others added 9 commits January 22, 2018 15:44
Changed default NDK version from 4.8 to 4.9
Seems like `RELEASE.TXT` is gone, so `arch` is now used to
determine if we're running on 64bit or not. I'm unsure how
to properly check for this on Windows, though.
Android NDK r13 appears to have removed a level of nesting
within LLVM libc++. The "libcxx" subdirectory no longer exists.
@AndrewSB AndrewSB force-pushed the android-instructions branch from e65fcbd to 77a1cbe Compare March 3, 2018 02:45
@AndrewSB
Copy link
Member Author

AndrewSB commented Mar 3, 2018

This PR depends on #6 being merged first

gonzalolarralde and others added 5 commits March 5, 2018 15:15
Swift is expecting this libraries to be named `icuucswift` for Android to avoid name collision with Android's `icuuc`.

This should be temporal, a more appropriate solution (if any) should be applied to solve this lib conflict.
These patches _should_ be able to be applied using `patch`, they
automate the changeset currently described at apple/swift/docs/Android.md
@AndrewSB AndrewSB force-pushed the android-instructions branch from 77a1cbe to 3e45a00 Compare March 5, 2018 23:16
lanza pushed a commit that referenced this pull request May 4, 2018
add option to build shared icu libraries instead of static
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants