forked from pelya/libiconv-libicu-android
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create build-android.sh and update instructions #8
Open
AndrewSB
wants to merge
14
commits into
SwiftAndroid:master
Choose a base branch
from
AndrewSB:android-instructions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eabi-v7a, build icu 55.1
Changed default NDK version from 4.8 to 4.9
Seems like `RELEASE.TXT` is gone, so `arch` is now used to determine if we're running on 64bit or not. I'm unsure how to properly check for this on Windows, though.
Android NDK r13 appears to have removed a level of nesting within LLVM libc++. The "libcxx" subdirectory no longer exists.
AndrewSB
force-pushed
the
android-instructions
branch
from
March 3, 2018 02:45
e65fcbd
to
77a1cbe
Compare
This PR depends on #6 being merged first |
Swift is expecting this libraries to be named `icuucswift` for Android to avoid name collision with Android's `icuuc`. This should be temporal, a more appropriate solution (if any) should be applied to solve this lib conflict.
These patches _should_ be able to be applied using `patch`, they automate the changeset currently described at apple/swift/docs/Android.md
AndrewSB
force-pushed
the
android-instructions
branch
from
March 5, 2018 23:16
77a1cbe
to
3e45a00
Compare
lanza
pushed a commit
that referenced
this pull request
May 4, 2018
add option to build shared icu libraries instead of static
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5.
@lanza this is ready for you