Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move testimonials to KV #1

Open
fayazara opened this issue Sep 18, 2024 · 5 comments · May be fixed by #6
Open

Move testimonials to KV #1

fayazara opened this issue Sep 18, 2024 · 5 comments · May be fixed by #6
Labels
good first issue Good for newcomers

Comments

@fayazara
Copy link
Contributor

Make a CRUD action to Read, Create, Update and Delete testimonials from our KV store

@fayazara fayazara added the good first issue Good for newcomers label Sep 18, 2024
@lakshay-saini-au8
Copy link

@fayazara I am up to contribute to this
Possible to guide for the feature to implement

@fayazara
Copy link
Contributor Author

Hey @lakshay-saini-au8 Sure, Basically we'd need to create a new key called testimonials and store an array of objects in the below format

[
  {
      title: "Super Powerful",
      quote:
        "The stack that Supersaas is built upon is super powerful and easy to work with, especially when used with NuxtHub / Cloudflare. Fayaz has been super helpful in making it work and adopting feedback.",
      author: {
        name: "John Doe",
        description: "Freelancer/Software Engineer",
        avatar: {
          src: "https://pbs.twimg.com/profile_images/985092522329468928/qcfeEMbF_400x400.jpg",
          loading: "lazy",
        },
      },
  }
]

We can just stringify this array and perform CRUD operations on it via the admin settings page.

@mubaidr
Copy link

mubaidr commented Oct 4, 2024

I am willing to work on this. Can you please confirm if this is available to take.

@fayazara
Copy link
Contributor Author

@mubaidr Sure, please go ahead

@mubaidr
Copy link

mubaidr commented Oct 15, 2024

Awesome! Working on it!

mubaidr added a commit to mubaidr/lemonrepo that referenced this issue Oct 17, 2024
Currently testimonials are hardcoded, moved to the hub key-value storage

SupersaasHQ#1
@mubaidr mubaidr linked a pull request Oct 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants