-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS errors #27
Comments
angular-packery's bower dependencies includes Packery itself, but does not bundle the code. You still need to ensure that Packery is included in your HTML includes, along with angular-packery. |
Of course. Sorted that but now it's saying 'Draggabilly is not defined' even though I thought it was optional... |
At this point in time, Draggabilly is enabled by default. This is an oversight that we will be addressing in the next version update (issue #16). In the meantime, drag needs to be disabled if not desired:
|
Thanks. |
Can you put together an example of the issue on Plunker? Height of items is based on the CSS height of provided to the sizer class, as noted on the README doc. |
Yeah I'll get something up. |
So first Plunkr shows the images: Second example is more similar to the setup I have on the project, but typically it shows the images! however, there is a layout issue I can't have CSS classes because each image I get back is going to be a different size. So maybe I've missed the point of Packery? |
Here's a breakdown of the implementation issues... Yours: http://plnkr.co/edit/rAPPSWGd51KJZ3SfYUty?p=preview In this one, you had the Additionally, Yours: http://plnkr.co/edit/ePijl5PstKW4mnpTMPsS?p=preview Similar issue as before... The third example is the same as the second one. So that fix will address it as well. |
Oh wow, thanks very much. I actually had a lot more success with angular-masonry which I guess is very similar to this. So I'll compare the two. Thanks again. |
Closing in favor of issue #28. |
Quite possibly an issue with my code or with how I installed it but trying to use the example code gives the following errors:
ReferenceError: Packery is not defined
at Object.Packery
I had to install it by putting this in the bower file:
"angular-packery" : "1.0.3"
and running bower install
I've added 'angular-packery' to the module list, but do I need to include any other dependencies?
Thanks
The text was updated successfully, but these errors were encountered: