Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change load_config function to not use a global variable #1

Open
mryoho opened this issue Mar 11, 2019 · 1 comment
Open

Change load_config function to not use a global variable #1

mryoho opened this issue Mar 11, 2019 · 1 comment

Comments

@mryoho
Copy link
Collaborator

mryoho commented Mar 11, 2019

The load_config function in legacy is load into a global variable call config. This could cause problems with loading 2 config files.

E.g.: In the following config would be overwritten by the second load_config causing confusion

config = legacy.load_config('config1.ini')
config2 =  legacy.load_config('config2.ini')
@mryoho
Copy link
Collaborator Author

mryoho commented Jun 12, 2020

If there's a use case for multiple configs, then I'm totally open to suggested solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mryoho