Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get running on new node version + update depedencies and gulpfile and so on #4

Open
sudofox opened this issue Jun 8, 2022 · 4 comments
Assignees

Comments

@sudofox
Copy link
Member

sudofox commented Jun 8, 2022

No description provided.

@sudofox sudofox self-assigned this Jun 8, 2022
@sudofox
Copy link
Member Author

sudofox commented Jun 8, 2022

@jaames I'm going to do all the heavy lifting here to maintain this package, but would you happen to know which node version this was on when it started out?

I looked at NodeJS release history and picked out Node v8.4.0 but npm run build does not seem to produce output in dist/

[aburk@aburk-laptop Sudofont]$ node --version
v8.4.0
[aburk@aburk-laptop Sudofont]$ npm run build

> [email protected] build /home/aburk/git/Sudofont
> gulp build

[15:02:01] Using gulpfile ~/git/Sudofont/gulpfile.js
[15:02:01] Starting 'build'...
[15:02:02] Finished 'build' after 100 ms
[aburk@aburk-laptop Sudofont]$ ls dist
css  fonts  scss  svg  test.html
[aburk@aburk-laptop Sudofont]$ rm -rf dist
[aburk@aburk-laptop Sudofont]$ npm run build

> [email protected] build /home/aburk/git/Sudofont
> gulp build

[15:02:12] Using gulpfile ~/git/Sudofont/gulpfile.js
[15:02:12] Starting 'build'...
[15:02:12] Finished 'build' after 84 ms
[aburk@aburk-laptop Sudofont]$ ls dist
ls: cannot access 'dist': No such file or directory
[aburk@aburk-laptop Sudofont]$ 

If you're too busy, feel free to disregard this; I plan on taking up maintenance for this package anyway since I want to use it on Theatre, and I'm sure I can figure it out.

@sudofox
Copy link
Member Author

sudofox commented Jun 8, 2022

Okay, I'm pretty sure the issue here is related to me not being on a Mac + not having Sketch installed, the Sketch step is required and while there is an install-sketchtool.sh script, it seems to only be mac compatible lol.

@sudofox
Copy link
Member Author

sudofox commented Jun 8, 2022

Working to replace the gulp-sketch step, ran into an issue with the lib I tried to use, waiting for that.

design-ops/sketch-to-svg#24

@sudofox
Copy link
Member Author

sudofox commented Jun 9, 2022

i nixed the sketch dep entirely and wrote a custom gulp svg loader that will probably break when i upgrade it to gulp 4 lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant