Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image coloring in image visualizer blow up sometimes does not work #216

Open
andrewsu opened this issue Mar 12, 2019 · 1 comment
Open
Labels
bug ChlamBase ChlamBase specific issue

Comments

@andrewsu
Copy link
Member

For example, the thumbnail visualizer for https://chlambase.org/organism/471472/gene/CTL0370 correctly shows localization to the cell membrane and inclusion body membrane:

2019-03-12_16-25-52

But the full sized viewer shows no coloring.

2019-03-12_16-27-01

In contrast, both the thumbnail and full-sized views show up fine for https://chlambase.org/organism/471472/gene/CTL0050 (which localizes to EB and RB).

@andrewsu andrewsu added bug ChlamBase ChlamBase specific issue labels Mar 12, 2019
@djow2019
Copy link
Collaborator

djow2019 commented Mar 13, 2019

I am not sure what the exact reason is, but I did notice that this bug occurs for all genes with "host cell membrane" as a cc (you can verify this with the advanced search). However, all the other components work (EB. RB, host cell lipid droplets, etc.). The only thing I can think of is that the color of the membranes is done using the "stroke" attribute, whereas the other structures are colored with "fill". If that is indeed the case, then the library that we are using that enhances the image seems to have conflicts with setting the stroke.

Another idea might be that the enlarged image has a different xml structure than the smaller one, so the same paths/attributes might not exist.

Referenced lines: https://github.com/SuLab/WikiGenomesBase/blob/master/wiki/static/wiki/js/app/main-page/gene-overview/cell-visualizer-view/cell-visualizer-view.component.js#L82-L102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ChlamBase ChlamBase specific issue
Projects
None yet
Development

No branches or pull requests

2 participants