Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream open should not be automatic. #3

Open
F483 opened this issue Mar 30, 2016 · 1 comment
Open

Stream open should not be automatic. #3

F483 opened this issue Mar 30, 2016 · 1 comment
Assignees

Comments

@F483
Copy link
Contributor

F483 commented Mar 30, 2016

Currently when Alice requests to open a stream with Bob, Bob automatically accepts and returns the generated streamid.

This make all clients vulnerable to memory attacks. Instead there should be some mechanism where Bob must confirm the stream open and it quickly times out if he does not.

@F483 F483 self-assigned this Mar 30, 2016
@F483
Copy link
Contributor Author

F483 commented Mar 30, 2016

It may be better to have a stream limit and just close the oldest or least active. This may be better for the following reasons.

  • It keeps the interface simple.
  • Doing otherwise would just defer the attack vector to the user. It would be better to do this once correctly in storjnet instead of requesting users to duplicate the effort (likely badly or not at all).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant