Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading gameList from file fails if 'hours' or 'rating' is NULL #92

Open
Stevoisiak opened this issue Apr 8, 2017 · 0 comments
Open
Assignees

Comments

@Stevoisiak
Copy link
Owner

Stevoisiak commented Apr 8, 2017

Loading the gameList from a file will fail if the "hours played" or "rating" fields are empty. In theory, this should only happen if the game_list.csv file was manually edited.

The ideal fix would be to store hours and rating as Integer to allow null as a valid value to allow distinctions between "0 hours played" and the field being left empty.

Issue can be recreated by loading the following game_list.csv

"name","system","hours","completion","rating"
"Pong","AcornA","0","Unfinished","0"
"Flappy Bird","Droid","","Null","3"
"Super Mario Bros","NES","0","Completed","0"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant