New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate putting secret id in link to github #1

Open

Steven-Gassert opened this issue Sep 28, 2018 · 1 comment

Owner

Steven-Gassert commented Sep 28, 2018

right now when posting the authorization message to slack to allow users to follow a link back to github which allows them authenticate and create a personal access token, the link to the github page contains app secrets, there must be a better way to offer users this link

Owner Author

Steven-Gassert commented Sep 28, 2018

https://developer.github.com/apps/building-oauth-apps/authorizing-oauth-apps/
we must offer the user a 'get' request link, is there anyway we can prevent showing our users the standup-helper secrets?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment