Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileSluggy version 1.3.1 doesn't work in modx 2.7.3, php version 7.3 #26

Open
pawelpvi opened this issue May 1, 2020 · 2 comments
Open

Comments

@pawelpvi
Copy link

pawelpvi commented May 1, 2020

Filenames are not changed, eg: T%ąśds.txt uploaded with the same name

@pawelpvi
Copy link
Author

pawelpvi commented May 1, 2020

I found that it's related to conflict with plugin which is trying to send file to optimize with tinypng api. Setting different priority OnFileManagerUpload didn't solvedthe problem.

@jcdm
Copy link

jcdm commented Feb 5, 2021

I know it's almost a year later, but I can speak to a similar issue. I have a plugin which creates PDF thumbnails on upload but had the same issue - I needed it to run AFTER FileSluggy using the name that FileSluggy had given the file.

I have a PR sitting here that triggers the FileSluggyOnUpdateFilename event whether or not a rename took place. That allows you to chain your plugin to this while receiving some information about the media source etc. I've had this working with the MODX 2.7 family and now the 2.8 family as well. I cannot vouch for it under MODX 3.

If you make the changes to the FileSluggy plugin included in that PR then hook your tinypng plugin to the FileSluggy event instead of the upload event, you might find that gets you further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants