Skip to content

Latest commit

 

History

History
116 lines (80 loc) · 3.84 KB

require-tagless-components.md

File metadata and controls

116 lines (80 loc) · 3.84 KB

require-tagless-components

✅ The "extends": "plugin:ember/recommended" property in a configuration file enables this rule.

Disallows using the wrapper element of a component.

Ember allows you to disable the wrapper element on a component (turning it into a "tagless" component). This is now the preferred style and the only style allowed with Glimmer components.

Rule Details

Instead of having the wrapper element implicitly defined by the component, all DOM elements should be represented in the component's template.

Examples

Examples of incorrect code for this rule:

// "Classic"-class Ember components that have the default `tagName` of `div`
import Component from '@ember/component';

export default Component.extend({});
// "Classic"-class Ember components that have a `tagName` configured to something besides `''`
import Component from '@ember/component';

export default Component.extend({
  tagName: 'span'
});
// "Native"-class Ember components that have the default `tagName` of `div`
import Component from '@ember/component';

export default class MyComponent extends Component {}
// "Native"-class Ember components that have a `tagName` configured to something besides `''`
import Component from '@ember/component';

export default class MyComponent extends Component {
  tagName = 'span';
}
// "Native"-class Ember components that use the `@tagName` decorator configured to something besides `''`
import Component from '@ember/component';
import { tagName } from '@ember-decorators/component';

@tagName('span')
export default class MyComponent extends Component {}

Examples of correct code for this rule:

// "Class"-class Ember components that have a `tagName` configured to `''`
import Component from '@ember/component';

export default Component.extend({
  tagName: ''
});
// "Native"-class Ember components that have a `tagName` configured to `''`
import Component from '@ember/component';

export default class MyComponent extends Component {
  tagName = '';
}
// "Native"-class Ember components that use the `@tagName` decorator configured `''`
import Component from '@ember/component';
import { tagName } from '@ember-decorators/component';

@tagName('')
export default class MyComponent extends Component {}
// Glimmer components never have a `tagName` and are always valid
import Component from '@glimmer/component';

export default class MyComponent extends Component {}

Caveats

  • Rule does not catch cases where a Mixin is included to configure the tagName property.

Fixing This Rule

You can take two approaches to fixing this rule:

  1. Convert to a Glimmer component
  2. Set the tagName in your Ember component definition to '' (an empty string)

Note that you might want to wrap the component template in an additional element, if the usage of the component expects the wrapping element to exist. Classes and attributes should be applied to that wrapper element, as well as forwarding any attributes assigned to the component through ...attributes.

When Not To Use It

  • If you are not prepared to convert your components to be tag-less, wrapping the associated template in a tag and applying ...attributes where appropriate, you should not enable this rule.

Further Reading

  • Glimmer Components
    • Glimmer components are "the future" for Ember, and are always tagless. Using them now, or changing your Ember components to be tagless, helps to modernize your codebase and prepare for a point in the future where components never have a wrapper element.
  • RFC #311 "Angle Bracket Invocation" (HTML Attributes section)
    • Discusses forwarding attributes on a component to a DOM element using ...attributes