Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow paths in plugin.json publish.image field #17

Open
NGnius opened this issue Jul 11, 2022 · 4 comments
Open

Allow paths in plugin.json publish.image field #17

NGnius opened this issue Jul 11, 2022 · 4 comments
Assignees
@gbdlin @TrainDoctor
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@NGnius
Copy link
Contributor

NGnius commented Jul 11, 2022

Currently the image field only accepts links to an image, but they are all getting uploaded to the store CDN anyway.
It would make sense to also accept a file path to an image contained within the plugin's git repo since the link is only used by the CI anyway.

For a bit more context (discord link to SD Homebrew guild): https://discord.com/channels/960281551428522045/960284311444131840/995760749764935790
@TrainDoctor TrainDoctor added the enhancement New feature or request label Jul 11, 2022
@TrainDoctor TrainDoctor moved this to 🆕 New in React Update Project Jul 14, 2022
@TrainDoctor TrainDoctor moved this from 🆕 New to 📋 Backlog in React Update Project Aug 17, 2022
@TrainDoctor TrainDoctor moved this from 📋 Backlog to 🆕 New in React Update Project Aug 18, 2022
@TrainDoctor TrainDoctor moved this from 🆕 New to 📋 Backlog in React Update Project Aug 25, 2022
@TrainDoctor
Copy link
Member

@gbdlin is now working on store features that would provide this functionality.

@TrainDoctor TrainDoctor moved this to 🆕 New in SDH Tracker Sep 19, 2022
@TrainDoctor TrainDoctor added the help wanted Extra attention is needed label Sep 25, 2022
@TrainDoctor TrainDoctor moved this from 🆕 New to 📋 Backlog in SDH Tracker Sep 25, 2022
@TrainDoctor TrainDoctor moved this from 📋 Backlog to 🆕 New in SDH Tracker Oct 23, 2022
@TrainDoctor TrainDoctor moved this from 🆕 New to 🏗 In progress in SDH Tracker Oct 23, 2022
@TrainDoctor
Copy link
Member

We might return to this later, but this is going to have to go onto the backlog as we've grown busy with a bunch of other tasks.

@TrainDoctor TrainDoctor moved this from 🏗 In progress to 📋 Backlog in SDH Tracker Dec 10, 2022
@AAGaming00 AAGaming00 moved this to Todo in Store and CI Feb 4, 2023
@AAGaming00 AAGaming00 removed the status in Store and CI Feb 4, 2023
@TrainDoctor
Copy link
Member

With new Plugin V2 plans, it would make sense instead for the image to grabbed by CI during the upload to store.

geeksville pushed a commit to geeksville/decky-plugin-database that referenced this issue Mar 2, 2024
@xndr78
Makefile helper tools, bump frontend UI version (SteamDeckHomebrew#17)
d81b0bb 
* Makefile helper tools, frontend UI lib updated, option added to build plugin in docker

* docker/makefile cleanup
@TrainDoctor
Copy link
Member

@gbdlin please let me know if this work was ever completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbdlin gbdlin

@TrainDoctor TrainDoctor

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
SDH Tracker
Status: 📋 Backlog
React Update Project
Status: 📋 Backlog
Store and CI
Status: No status
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gbdlin @WerWolv @TrainDoctor @NGnius