Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement reproducible builds from the command line #23

Open
nikita-tukkel opened this issue Jan 11, 2023 · 0 comments
Open

Implement reproducible builds from the command line #23

nikita-tukkel opened this issue Jan 11, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@nikita-tukkel
Copy link

nikita-tukkel commented Jan 11, 2023

At this moment, looks like it is not possible to build the release without having Visual Studio installed. There are also some not obvious expectations from the environment setup to build successfully. This prevents people who don’t want to install Visual Studio or not proficient enough in the .Net world from contributing even a trivial pull requests.

The better build configuration must meet the following requirements:

  1. Compilation is performed with a single console command, e.g. dotnet build

  2. Release zip is assembled with a single console command also, e.g. dotnet build -target:ReleaseZip

  3. Visual Studio is not required.

  4. Only the correct set of command-line tools is required (dotnet, msbuild, nuget, SDK) and their versions are documented.

  5. All “standard” dependencies are defined via nuget.

  6. All “non-standard” dependencies are defined in a reliable and obvious fashion, e.g. (1) all dlls from Stationeers\rocketstation_Data\Managed and (2) all dlls from Stationeers\AddonManager. Nothing more, no extra expectations, no “go to X and download Y”, no copying files around, no surprises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants