Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates few project dependencies #181

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

AdiAkhileshSingh15
Copy link
Contributor

@AdiAkhileshSingh15 AdiAkhileshSingh15 commented Mar 8, 2024

Changes Summary

This PR aims to update he existing dependencies to the latest LTS (Long Term Support) version.

The following dependencies have been updated:

devDependencies:

  1. @babel/preset-env: Updated to version ^7.24.0
  2. chalk: Updated to version ^4.1.2
  3. css-loader: Updated to version ^6.10.0
  4. electron: Updated to version ^29.1.1
  5. electron-builder: Updated to version ^24.13.3
  6. fbjs-scripts: Updated to version ^3.0.1
  7. husky: Updated to version ^9.0.11
  8. lint-staged: Updated to version ^15.2.2
  9. react-test-renderer: Updated to version ^18.2.0
  10. rimraf: Updated to version ^5.0.5
  11. sass-loader: Updated to version ^14.1.1
  12. sinon: Updated to version ^17.0.1
  13. style-loader: Updated to version ^2.0.0
  14. stylelint: Updated to version ^16.2.1
  15. stylelint-config-prettier: Updated to version ^9.0.5
  16. stylelint-config-standard: Updated to version ^36.0.0
  17. testcafe-react-selectors: Updated to version ^5.0.3

dependencies:

  1. @mui/lab: Updated to version ^5.0.0-alpha.167
  2. github-markdown-css: Updated to version ^5.5.1
  3. jest-extended: Updated to version 4.0.2

These tasks also include replacing the @babel/plugin-proposal-private-property-in-object with plugin-transform-private-property-in-object, as the npm suggests that @babel/plugin-proposal-private-property-in-object is deprecated. source.

All the dependencies are updated to their latest LTS version, except for chalk.
As chalk LTS version v5 was giving some build and dev errors due to the way imports were being made in the module.
"IMPORTANT: Chalk 5 is ESM. If you want to use Chalk with TypeScript or a build tool, you will probably want to use Chalk 4 for now."
I'd recommend you to go through this discussion. Pure ESM
Though, I don't think keeping it to an old yet newer version is helpful in long-run. It would require us to move towards dynamic imports for ESM version.

Also, one small update in github-markdown-css requires us to specify import of light scheme of styling unlike the previous version. Actually, I came to know that it reads the color-scheme of the app or the specific component, I tried to set the color scheme that way, but it didn't help, so, specifying the module import came in pretty useful.

Related Issue

Fixes: #171

Testing:

After updating dependencies, ran different checks using these commands locally to ensure functionality remains intact.
Use commands:

  • yarn test - all tests passed
  • yarn dev - no UI fails detected
  • yarn build - no build fails detected
  • yarn dev - no new consol errors detected for any dependencies

Reviewer(s)

@lrasmus

Copy link
Contributor

@Abhijay007 Abhijay007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍. One more thing @AdiAkhileshSingh15, could you please squash these commits into one?

@AdiAkhileshSingh15
Copy link
Contributor Author

Yeah sure! @Abhijay007

@AdiAkhileshSingh15
Copy link
Contributor Author

@Abhijay007 Can I take up some more dependency updates in this branch or do I need to get these merged to master first?
I'll ensure to squash the upcoming commits into one while I do so.

@Abhijay007
Copy link
Contributor

Abhijay007 commented Mar 9, 2024

@Abhijay007 Can I take up some more dependency updates in this branch or do I need to get these merged to master first? I'll ensure to squash the upcoming commits into one while I do so.

sure @AdiAkhileshSingh15 you can add more dependencies updates in this branch, just update that in both the issue list and PR description.

@AdiAkhileshSingh15
Copy link
Contributor Author

Ohk sure! @Abhijay007

@AdiAkhileshSingh15
Copy link
Contributor Author

In these changes, I couldn't update style-loader to v3, max it could have been updated to without breaking the dev was ^2.0.0. Some solutions on the web suggested to not use style-loader alongwith css-loader. Removing it didn't seem feasible so I updated it till v2, which kinda seems fine knowing that style-loader comes to use only in dev.

Screenshot from 2024-03-09 17-28-36
Here is the error message attached.
It seems to have something to do with react-hot-loader, which I didn't find anything useful about anywhere, also, updating it doesn't help.

@AdiAkhileshSingh15
Copy link
Contributor Author

AdiAkhileshSingh15 commented Mar 9, 2024

Changes made with my last commit to this branch:

devDependencies:

  1. sass-loader: Updated to version ^14.1.1
  2. sinon: Updated to version ^17.0.1
  3. style-loader: Updated to version ^2.0.0
  4. stylelint: Updated to version ^16.2.1
  5. stylelint-config-prettier: Updated to version ^9.0.5
  6. stylelint-config-standard: Updated to version ^36.0.0
  7. testcafe-react-selectors: Updated to version ^5.0.3

dependencies:

  1. jest-extended: Updated to version 4.0.2

commit 00d9e2c
Author: AdiAkhileshSingh15 <[email protected]>
Date:   Sat Mar 9 18:02:43 2024 +0530

    updates sass-loader sinon style-loader stylelint stylelint-config-prettier stylelint-config-standard testcafe-react-selectors & jest-extended

    Signed-off-by: AdiAkhileshSingh15 <[email protected]>

commit f94ef9a
Author: AdiAkhileshSingh15 <[email protected]>
Date:   Sat Mar 9 13:13:50 2024 +0530

    Squashed commit of the following:

    commit 71ca69a
    Author: AdiAkhileshSingh15 <[email protected]>
    Date:   Sat Mar 9 02:54:52 2024 +0530

        updates github-markdown-css

        Signed-off-by: AdiAkhileshSingh15 <[email protected]>

    commit 13a4b00
    Author: AdiAkhileshSingh15 <[email protected]>
    Date:   Sat Mar 9 01:59:34 2024 +0530

        testing husky

        Signed-off-by: AdiAkhileshSingh15 <[email protected]>

    commit ca1f1c6
    Author: AdiAkhileshSingh15 <[email protected]>
    Date:   Sat Mar 9 01:58:19 2024 +0530

        testing husky

        Signed-off-by: AdiAkhileshSingh15 <[email protected]>

    commit cd169f2
    Author: AdiAkhileshSingh15 <[email protected]>
    Date:   Sat Mar 9 01:47:45 2024 +0530

        testing husky

        Signed-off-by: AdiAkhileshSingh15 <[email protected]>

    commit 81cab64
    Author: AdiAkhileshSingh15 <[email protected]>
    Date:   Sat Mar 9 01:46:56 2024 +0530

        testing husky

        Signed-off-by: AdiAkhileshSingh15 <[email protected]>

    commit f8af801
    Author: AdiAkhileshSingh15 <[email protected]>
    Date:   Sat Mar 9 01:45:58 2024 +0530

        testing husky

        Signed-off-by: AdiAkhileshSingh15 <[email protected]>

    commit 7bfdc02
    Author: AdiAkhileshSingh15 <[email protected]>
    Date:   Sat Mar 9 01:37:57 2024 +0530

        updates rimraf

        Signed-off-by: AdiAkhileshSingh15 <[email protected]>

    commit 15fc252
    Author: AdiAkhileshSingh15 <[email protected]>
    Date:   Sat Mar 9 01:30:41 2024 +0530

        updates react-test-renderer

        Signed-off-by: AdiAkhileshSingh15 <[email protected]>

    commit 2fd92d6
    Author: AdiAkhileshSingh15 <[email protected]>
    Date:   Sat Mar 9 01:25:05 2024 +0530

        updates lint-staged

        Signed-off-by: AdiAkhileshSingh15 <[email protected]>

    commit 4f6bcce
    Author: AdiAkhileshSingh15 <[email protected]>
    Date:   Sat Mar 9 01:06:03 2024 +0530

        updates husky

        Signed-off-by: AdiAkhileshSingh15 <[email protected]>

    commit eda9bb2
    Author: AdiAkhileshSingh15 <[email protected]>
    Date:   Sat Mar 9 01:04:07 2024 +0530

        updates fbjs-scripts

        Signed-off-by: AdiAkhileshSingh15 <[email protected]>

    commit aedd2d1
    Author: AdiAkhileshSingh15 <[email protected]>
    Date:   Sat Mar 9 01:01:43 2024 +0530

        updates css-loader

        Signed-off-by: AdiAkhileshSingh15 <[email protected]>

    commit 689b128
    Author: AdiAkhileshSingh15 <[email protected]>
    Date:   Sat Mar 9 00:59:05 2024 +0530

        updates chalk and @mui/lab

        Signed-off-by: AdiAkhileshSingh15 <[email protected]>

    commit 0800321
    Author: AdiAkhileshSingh15 <[email protected]>
    Date:   Fri Mar 8 23:38:33 2024 +0530

        updates electron-builder

        Signed-off-by: AdiAkhileshSingh15 <[email protected]>

    commit c22ca74
    Author: AdiAkhileshSingh15 <[email protected]>
    Date:   Fri Mar 8 23:32:53 2024 +0530

        updates electron

        Signed-off-by: AdiAkhileshSingh15 <[email protected]>

    commit f7ef55a
    Author: AdiAkhileshSingh15 <[email protected]>
    Date:   Fri Mar 8 23:28:16 2024 +0530

        updates @babel/preset-env

        Signed-off-by: AdiAkhileshSingh15 <[email protected]>
@AdiAkhileshSingh15
Copy link
Contributor Author

Updating stylelint threw a console error, Module build failed: Error: ENOENT: no such file or directory which didn't affect the overall working of the application UI, neither did it face any build or test errors.
This error came for some unified pkg, as it looked for a is-plain-obj folder, which was replaced by is-buffer folder in the node modules, most sources on the web suggested to reinstall the node modules or ignore this error.

Screenshot from 2024-03-09 17-35-25

@Abhijay007
Copy link
Contributor

Updating stylelint threw a console error, Module build failed: Error: ENOENT: no such file or directory which didn't affect the overall working of the application UI, neither did it face any build or test errors. This error came for some unified pkg, as it looked for a is-plain-obj folder, which was replaced by is-buffer folder in the node modules, most sources on the web suggested to reinstall the node modules or ignore this error.

Screenshot from 2024-03-09 17-35-25

@AdiAkhileshSingh15, thanks for looking into this but could you please try reinstalling the 'node modules' as the sources suggest? If errors persist afterward, it's better to revert this change. Although it may not directly impact the high-level functionality, it could be causing some hidden errors or issues.

@AdiAkhileshSingh15
Copy link
Contributor Author

Screenshot from 2024-03-09 23-15-03
Reinstalling node modules alongwith restarting dev server cleaned the console 👍🏻 No more such Module build failed: Error: ENOENT: no such file or directory errors.

@lrasmus
Copy link
Contributor

lrasmus commented Mar 11, 2024

Sorry for the delays, thank you so much @AdiAkhileshSingh15 for the changes, and @Abhijay007 for keeping this going while I was away!

@lrasmus lrasmus merged commit 1a52f3b into StatTag:master Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor : Update Project Dependencies
3 participants