-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates few project dependencies #181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍. One more thing @AdiAkhileshSingh15, could you please squash these commits into one?
Yeah sure! @Abhijay007 |
71ca69a
to
f94ef9a
Compare
@Abhijay007 Can I take up some more dependency updates in this branch or do I need to get these merged to master first? |
sure @AdiAkhileshSingh15 you can add more dependencies updates in this branch, just update that in both the issue list and PR description. |
Ohk sure! @Abhijay007 |
Changes made with my last commit to this branch: devDependencies:
dependencies:
|
commit 00d9e2c Author: AdiAkhileshSingh15 <[email protected]> Date: Sat Mar 9 18:02:43 2024 +0530 updates sass-loader sinon style-loader stylelint stylelint-config-prettier stylelint-config-standard testcafe-react-selectors & jest-extended Signed-off-by: AdiAkhileshSingh15 <[email protected]> commit f94ef9a Author: AdiAkhileshSingh15 <[email protected]> Date: Sat Mar 9 13:13:50 2024 +0530 Squashed commit of the following: commit 71ca69a Author: AdiAkhileshSingh15 <[email protected]> Date: Sat Mar 9 02:54:52 2024 +0530 updates github-markdown-css Signed-off-by: AdiAkhileshSingh15 <[email protected]> commit 13a4b00 Author: AdiAkhileshSingh15 <[email protected]> Date: Sat Mar 9 01:59:34 2024 +0530 testing husky Signed-off-by: AdiAkhileshSingh15 <[email protected]> commit ca1f1c6 Author: AdiAkhileshSingh15 <[email protected]> Date: Sat Mar 9 01:58:19 2024 +0530 testing husky Signed-off-by: AdiAkhileshSingh15 <[email protected]> commit cd169f2 Author: AdiAkhileshSingh15 <[email protected]> Date: Sat Mar 9 01:47:45 2024 +0530 testing husky Signed-off-by: AdiAkhileshSingh15 <[email protected]> commit 81cab64 Author: AdiAkhileshSingh15 <[email protected]> Date: Sat Mar 9 01:46:56 2024 +0530 testing husky Signed-off-by: AdiAkhileshSingh15 <[email protected]> commit f8af801 Author: AdiAkhileshSingh15 <[email protected]> Date: Sat Mar 9 01:45:58 2024 +0530 testing husky Signed-off-by: AdiAkhileshSingh15 <[email protected]> commit 7bfdc02 Author: AdiAkhileshSingh15 <[email protected]> Date: Sat Mar 9 01:37:57 2024 +0530 updates rimraf Signed-off-by: AdiAkhileshSingh15 <[email protected]> commit 15fc252 Author: AdiAkhileshSingh15 <[email protected]> Date: Sat Mar 9 01:30:41 2024 +0530 updates react-test-renderer Signed-off-by: AdiAkhileshSingh15 <[email protected]> commit 2fd92d6 Author: AdiAkhileshSingh15 <[email protected]> Date: Sat Mar 9 01:25:05 2024 +0530 updates lint-staged Signed-off-by: AdiAkhileshSingh15 <[email protected]> commit 4f6bcce Author: AdiAkhileshSingh15 <[email protected]> Date: Sat Mar 9 01:06:03 2024 +0530 updates husky Signed-off-by: AdiAkhileshSingh15 <[email protected]> commit eda9bb2 Author: AdiAkhileshSingh15 <[email protected]> Date: Sat Mar 9 01:04:07 2024 +0530 updates fbjs-scripts Signed-off-by: AdiAkhileshSingh15 <[email protected]> commit aedd2d1 Author: AdiAkhileshSingh15 <[email protected]> Date: Sat Mar 9 01:01:43 2024 +0530 updates css-loader Signed-off-by: AdiAkhileshSingh15 <[email protected]> commit 689b128 Author: AdiAkhileshSingh15 <[email protected]> Date: Sat Mar 9 00:59:05 2024 +0530 updates chalk and @mui/lab Signed-off-by: AdiAkhileshSingh15 <[email protected]> commit 0800321 Author: AdiAkhileshSingh15 <[email protected]> Date: Fri Mar 8 23:38:33 2024 +0530 updates electron-builder Signed-off-by: AdiAkhileshSingh15 <[email protected]> commit c22ca74 Author: AdiAkhileshSingh15 <[email protected]> Date: Fri Mar 8 23:32:53 2024 +0530 updates electron Signed-off-by: AdiAkhileshSingh15 <[email protected]> commit f7ef55a Author: AdiAkhileshSingh15 <[email protected]> Date: Fri Mar 8 23:28:16 2024 +0530 updates @babel/preset-env Signed-off-by: AdiAkhileshSingh15 <[email protected]>
00d9e2c
to
4fe4ec4
Compare
Updating |
@AdiAkhileshSingh15, thanks for looking into this but could you please try reinstalling the 'node modules' as the sources suggest? If errors persist afterward, it's better to revert this change. Although it may not directly impact the high-level functionality, it could be causing some hidden errors or issues. |
Sorry for the delays, thank you so much @AdiAkhileshSingh15 for the changes, and @Abhijay007 for keeping this going while I was away! |
Changes Summary
This PR aims to update he existing dependencies to the latest LTS (Long Term Support) version.
The following dependencies have been updated:
devDependencies:
^7.24.0
^4.1.2
^6.10.0
^29.1.1
^24.13.3
^3.0.1
^9.0.11
^15.2.2
^18.2.0
^5.0.5
^14.1.1
^17.0.1
^2.0.0
^16.2.1
^9.0.5
^36.0.0
^5.0.3
dependencies:
^5.0.0-alpha.167
^5.5.1
4.0.2
These tasks also include replacing the
@babel/plugin-proposal-private-property-in-object
withplugin-transform-private-property-in-object
, as the npm suggests that@babel/plugin-proposal-private-property-in-object
is deprecated. source.All the dependencies are updated to their latest LTS version, except for
chalk
.As
chalk
LTS version v5 was giving some build and dev errors due to the way imports were being made in the module."IMPORTANT: Chalk 5 is ESM. If you want to use Chalk with TypeScript or a build tool, you will probably want to use Chalk 4 for now."
I'd recommend you to go through this discussion. Pure ESM
Though, I don't think keeping it to an old yet newer version is helpful in long-run. It would require us to move towards
dynamic imports
for ESM version.Also, one small update in
github-markdown-css
requires us to specify import of light scheme of styling unlike the previous version. Actually, I came to know that it reads thecolor-scheme
of the app or the specific component, I tried to set the color scheme that way, but it didn't help, so, specifying the module import came in pretty useful.Related Issue
Fixes: #171
Testing:
After updating dependencies, ran different checks using these commands locally to ensure functionality remains intact.
Use commands:
Reviewer(s)
@lrasmus