From 09893f5d2cc005c87beea6564dbf38b974269dc9 Mon Sep 17 00:00:00 2001
From: Alireza Jafari <alirezaja1384@gmail.com>
Date: Sun, 8 Sep 2024 14:29:25 +0000
Subject: [PATCH] fix(build.yaml): createWorkflowDispatch() bug fixed

createWorkflowDispatch fixed,unnecessary PAT check removed, Update deployment step moved to its own job.
---
 .github/workflows/build.yaml | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index 26ca832..62a9042 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -81,16 +81,16 @@ jobs:
           tags: ${{ steps.metadata.outputs.tags }}
           labels: ${{ steps.metadata.outputs.labels }}
 
+  deployment:
+    name: Update deployment
+    runs-on: ubuntu-latest
+    needs: build
+    steps:
       - name: Update deployment
         uses: actions/github-script@v7
         with:
           github-token: ${{ secrets.DEPLOYMENT_PAT }}
           script: |
-            if(!'${{ secrets.DEPLOYMENT_PAT }}') {
-              console.log('No PAT provided, skipping deployment update')
-              return
-            }
-
             const owner = '${{ secrets.DEPLOYMENT_OWNER }}'
             const repo = '${{ secrets.DEPLOYMENT_REPO }}'
             const workflow_id = '${{ secrets.DEPLOYMENT_WORKFLOW }}'
@@ -103,7 +103,8 @@ jobs:
               return
             }
 
-            await github.actions.createWorkflowDispatch({
+            // Trigger the workflow dispatch using Octokit API (from github object)
+            await github.rest.actions.createWorkflowDispatch({
               owner: owner,
               repo: repo,
               workflow_id: workflow_id,
@@ -112,4 +113,6 @@ jobs:
                 version: version,
                 deployment: deployment_name,
               }
-            })
+            });
+  
+            console.log('Workflow dispatch triggered successfully.');
\ No newline at end of file