Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrency-unsafe interactions with PDFDocument #57

Open
1 task done
Supereg opened this issue Aug 29, 2024 · 1 comment · May be fixed by #58
Open
1 task done

Concurrency-unsafe interactions with PDFDocument #57

Supereg opened this issue Aug 29, 2024 · 1 comment · May be fixed by #58
Labels
bug Something isn't working

Comments

@Supereg
Copy link
Member

Supereg commented Aug 29, 2024

Description

The PR #51 added several concurrency issues that makes this package not compile in Swift 6 mode. The problem manifest around the ConsentDocumentExport actor. In its current design in requires the PDFDocument to cross isolation boundaries which is not possible as the type is not Sendable. The PDFDocument is an open class and therefore cannot be Sendable by definition.

Generally

Reproduction

Just compile the package, ideally with the latest Xcode 16 release.

Expected behavior

SpeziOnboarding should be compatible with Swift 6.

Additional context

Non-sendable types can cross actor boundaries, if they are passed as sending parameters. A solution to this problem might need to investigate new language features of the Swift 6 toolchain.

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@Supereg Supereg added the bug Something isn't working label Aug 29, 2024
@Supereg Supereg linked a pull request Aug 29, 2024 that will close this issue
1 task
@Supereg Supereg linked a pull request Aug 29, 2024 that will close this issue
1 task
@PSchmiedmayer
Copy link
Member

Thank you for taking a look at this @Supereg; I added a longer comment in #58 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

2 participants