Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support overriding the navigation title of Account Overview #48

Open
1 task done
Supereg opened this issue Feb 20, 2024 · 1 comment
Open
1 task done

Support overriding the navigation title of Account Overview #48

Supereg opened this issue Feb 20, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Supereg
Copy link
Member

Supereg commented Feb 20, 2024

Problem

The AccountOverview provides a default navigation title out of the box. However, in a certain context if might be desirable to override this (e.g., if an Account has a more concrete semantic like "Care Provider", ...).

Solution

With SwiftUI it is currently not possible to overwrite the navigation title from the outside (not sure why honestly?). Therefore, we would need to find a way to make such changes possible. Two straightforward approaches would be to a) just add a new init parameter to specify an optional argument or b) just remove the default navigation title and allow complete customization. Approach a) is probably that least SwiftUI-like approach.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@Supereg Supereg added the enhancement New feature or request label Feb 20, 2024
@PSchmiedmayer
Copy link
Member

Approach b) probably makes sense. There is probably no way to inspect the navigation title from the environment to see if it was already defined from an outside view? If not, I would probably suggest to remove the internal usage and allow that to be defined by the user of the view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Backlog
Development

No branches or pull requests

2 participants