Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realm: performance regression in cuPyNumeric CFD code #1817

Open
ipdemes opened this issue Jan 6, 2025 · 4 comments
Open

Realm: performance regression in cuPyNumeric CFD code #1817

ipdemes opened this issue Jan 6, 2025 · 4 comments
Assignees

Comments

@ipdemes
Copy link

ipdemes commented Jan 6, 2025

This commit https://gitlab.com/StanfordLegion/legion/-/commit/b1bb4babd7e6f7d37dcadf8bc62ce41e8266bf6e resulted in large regression in cuPyNumeric CFD benchmark.

@apryakhin
Copy link
Contributor

@ipdemes Are we using reductions in "CFD benchmark"?

@ipdemes
Copy link
Author

ipdemes commented Jan 8, 2025

We call "sum" only a couple of times , both shouldn't affect execution time. So there should be something else in this PR that effected performance

@eddy16112
Copy link
Contributor

That PR changes the way of registering a reduction. @ipdemes Do you register a reduction after the top-level task is launched? Do you include the runtime startup into your timing?

@apryakhin
Copy link
Contributor

apryakhin commented Jan 9, 2025

The redop registration shouldn't be on a critical path. @eddy16112 Can you please check if we can catch this in our perf regression test suite? If we don't have redops in them I think it will worth adding a modified version of `test/realm/simple_reduce.cc" test or whatever else test is necessary to be able to catch this regression in our tests.

@ipdemes I know some context on this was in the slack thread. Could you please copy-paste some of the information from there in here, so we have everything in one place...e.g links to the benchmark results/configurations and how did you find the offending change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants