Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Prefix checking use Erlang binary matching #3

Closed
ProducerMatt opened this issue Mar 12, 2024 · 1 comment · Fixed by #16
Closed

Make Prefix checking use Erlang binary matching #3

ProducerMatt opened this issue Mar 12, 2024 · 1 comment · Fixed by #16
Labels
enhancement New feature or request

Comments

@ProducerMatt
Copy link
Member

No description provided.

@ProducerMatt ProducerMatt moved this from Backlog to Ready in Stampede development tracking Mar 21, 2024
@ProducerMatt ProducerMatt added the enhancement New feature or request label Mar 21, 2024
@ProducerMatt ProducerMatt linked a pull request Jun 13, 2024 that will close this issue
Help plugin #16
Merged
@ProducerMatt
Copy link
Member Author

ProducerMatt commented Jun 13, 2024 •
edited
Loading

Because binary matching can't be limited to the start of the string, I chose to use a list of binaries. Regex matching was slower.

stampede/bench/FINDINGS.txt

Line 41 in c2adcb9

BINARY MATCHING FROM PREMADE LIST IS FASTER THAN REGEX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Help plugin StampyAI/stampede
1 participant
@ProducerMatt