Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sections of styled text (italic, bold, etc) which contain multiple textRuns render incorrectly #46

Open
ChrisRimmer opened this issue May 23, 2023 · 1 comment
Labels
bug Something isn't working parser

Comments

@ChrisRimmer
Copy link
Collaborator

When rendering something like the image caption "Feature visualisation [...]" in this doc the text is broken into three pieces, each of which gets a set of asterisks around it to make it bold. This results in *Feature visualization of a neuron that corresponds to dog-like features (**[image source](https://distill.pub/2020/circuits/zoom-in/)**)* which is understandably interpreted by the markdown renderer as a bold segment inside an italic one, rather than as three italic segments back to back.

Seems super minor so I'm going to call it low priority for now, but it seems good to have a record of it

@ChrisRimmer ChrisRimmer added bug Something isn't working parser labels May 23, 2023
@LeMurphant
Copy link
Contributor

I've also seen traces of this happening in #69

e.g. **A****lignment is hard like cryptographic security is hard: you** **have to plan for the possibility of intelligent** **adversaries.**

I think it's minor enough as well, especially if we can use blockquotes, but worth keeping in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser
Projects
None yet
Development

No branches or pull requests

2 participants