Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration Notes #95

Open
i5hi opened this issue Aug 2, 2023 · 5 comments
Open

Migration Notes #95

i5hi opened this issue Aug 2, 2023 · 5 comments
Assignees

Comments

@i5hi
Copy link
Contributor

i5hi commented Aug 2, 2023

This repo will be deprecated and this issue is to record notes for migration to a new repo.

The main reason is a change in the core architecture of the flutter app. We have learned a lot from development of this codebase and there are several core changes that will make management, contribution and reproducible builds a lot easier.

Some notable architectural changes:

  • maintain stackmate-core and cpclient as a git submodules (makes repro builds easier)
  • top level directory structure should reflect app pages (makes contribution easier)

Core features:

  • basic single signature wallet (all existing features)
  • labeling
  • coin selection
  • bip47 payment codes
  • border wallets
  • multi signature w/ standardized script backups
  • e2ee comms for script coordination (cypherpost)
  • FROST?
@i5hi i5hi assigned i5hi and yshwanth Aug 2, 2023
@i5hi
Copy link
Contributor Author

i5hi commented Aug 2, 2023

Let this be a chance for us to build sloe and steady with attention to details and not have to leave work for later refactoring. Especially in the early stages of migration where we set core patterns in place.

@i5hi
Copy link
Contributor Author

i5hi commented Aug 2, 2023

There is a case to be made to avoid starting a new repo and just update this repo. We will discuss and evaluate trade offs here.

@jodobear
Copy link

jodobear commented Aug 5, 2023

Let this be a chance for us to build sloe and steady with attention to details and not have to leave work for later refactoring. Especially in the early stages of migration where we set core patterns in place.

First order of business should be to establish our Style Guide so that the code is consistent.

Secondly, study the Design Guide so that we can have some standardization of our UI/UX.

There is a case to be made to avoid starting a new repo and just update this repo. We will discuss and evaluate trade offs here.

Main reason to NOT create a new repo; the POW history will be erased. Better to clean this one. Need an ACK so i can start doing it.

@i5hi
Copy link
Contributor Author

i5hi commented Aug 6, 2023

ACK

@i5hi
Copy link
Contributor Author

i5hi commented Aug 6, 2023

Share some style guide exmples here @jodobear

I have never really developed a style guide before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants