Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: stacked cli hangs when not connected to network and analytics are enabled #1140

Open
pcj opened this issue Oct 31, 2024 · 2 comments · May be fixed by Stacked-Org/cli#51
Open

[bug]: stacked cli hangs when not connected to network and analytics are enabled #1140

pcj opened this issue Oct 31, 2024 · 2 comments · May be fixed by Stacked-Org/cli#51
Labels
p2 Second highest Priority

Comments

@pcj
Copy link

pcj commented Oct 31, 2024

Describe the bug

I was quite surprised to find that when my laptop is not connected to WiFi, I cannot use the CLI as it hangs and there is no help info for enable/disable analytics.

I had to look through the source code to see that it is doing this, I don't recall opting-in but I guess I must have on first run.

Can we at least have cli options to disable analytics? Perhaps stacked analytics --[no]-enable or something?

What operating system do you use?

macOS

Information about the installed tooling

stacked -v
1.13.1

Steps to reproduce the issue

...

Expected behavior

...

Screenshots

No response

Additional Context

No response

@Pebkac03 Pebkac03 linked a pull request Dec 10, 2024 that will close this issue
@Pebkac03
Copy link

Hi.

Seems to me the issue isn't analytics (it seems to be temporarily disabled in code) but rather the default behaviour of build_runner being to run pub_get before running. Should be fixable by adding a config option for disabling this. I've created a PR adding an offline_mode to the stacked.json.

@FilledStacks
Copy link
Contributor

@pcj we actually did disable analytics, so it's quite interesting that this happens.

Will checkout PR from @Pebkac03 now.

@FilledStacks FilledStacks added the p2 Second highest Priority label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 Second highest Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants