Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove required_ from meta.required_provider and preserve backward compatibility #166

Open
2 tasks
samriddhi99 opened this issue Aug 8, 2024 · 1 comment
Open
2 tasks
Labels
good first issue Good for newcomers

Comments

@samriddhi99
Copy link
Contributor

We need to remove the required_ prefix from the meta.required_provider key in policies. The new key should be meta.provider. Also, we must ensure backward compatibility so that existing policies using meta.required_provider continue to function correctly.

  • Update the core, specifically the function start_policy_evaluation_from_dict to handle the above case
  • Write tests to ensure that policies with required_provider, and provider, both work.
@samriddhi99 samriddhi99 added the good first issue Good for newcomers label Aug 8, 2024
@muddi900
Copy link

muddi900 commented Aug 9, 2024

I am interested in contributing. However, I get FileNotFound for plan.json when I run the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants