Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up some Dart lint recommendations? #344

Open
tyler-jewell opened this issue Dec 15, 2022 · 2 comments
Open

Clean up some Dart lint recommendations? #344

tyler-jewell opened this issue Dec 15, 2022 · 2 comments

Comments

@tyler-jewell
Copy link

I just forked this repo and want to say job well done. I really like the structure and want to contribute all I can. I am seeing quite a few Dart lint recommendations on my end. Would it be ok if I just submitted a PR correcting some of them?

I would say 80% of them are recommending lambda tear-offs which will make the code a lot cleaner:

Now:

image

After:

image

@github-actions
Copy link

👋 Thanks for reporting! @robrbecker will take a look.

@tyler-jewell
Copy link
Author

I am not able to tie this to the PR I just created. Here's the link:

#345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant