Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: change Message and all composed classes from class to case class #169

Open
Woodz opened this issue Mar 26, 2019 · 0 comments
Open

Comments

@Woodz
Copy link

Woodz commented Mar 26, 2019

Currently, Message is a final class with public fields that extends from Function1. This causes problems with logging and testing as easy visualisation and comparison is not possible. For example, Message.toString returns <function1> and message1 shouldBe message2 returns assertion failed: expected <function1>, found <function1>. By changing Message and all contained classes (e.g. PublisherImpl and DefiningPublisher) to case classes, toString and equals will automatically be provided, which will make the API easier to debug and test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant