Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 shank probe issue - suggestion for new release. #225

Open
JoeZiminski opened this issue Oct 17, 2023 · 1 comment
Open

4 shank probe issue - suggestion for new release. #225

JoeZiminski opened this issue Oct 17, 2023 · 1 comment

Comments

@JoeZiminski
Copy link

Hi All,

We recently ran into issue #200 for the 4-shank probe, that was fixed by either downgrading to 0.2.16 or using the dev version (i.e. this is broken in 0.2.17). I would suggest a release is made ASAP to make sure the pip-installable version does not have this bug, as it is a little subtle and users might not immediately realise.

I saw a note on the testing in #205, could the asserts be changed to check exactly against hard-coded positions as specified in the .meta file? This would be a little time consuming to extract these for each metadata file in the test suite but would pay off going forward, happy to help with this!

@alejoe91
Copy link
Member

Hi @JoeZiminski

Yeah I think we can definitely cut a new release. Let use get this merged too #217, as commercial NP2 problems will be rolling soon.

@samuelgarcia is that ok for you?

Regarding the assertion, I agree we can remove them. Can you make a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants