Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot_probe() requires xlims and ylims to be defined for either to work #119

Open
D1o0g9s opened this issue Jul 26, 2022 · 1 comment
Open
Labels
question Further information is requested

Comments

@D1o0g9s
Copy link

D1o0g9s commented Jul 26, 2022

if xlims is None or ylims is None or (zlims is None and probe.ndim == 3):
xlims, ylims, zlims = get_auto_lims(probe)

It's unclear that both xlims and ylims are both needed for plotting to be limited in either of these dimensions individually. Perhaps this is unintended consequence, and we should be able to set an automatic limit for the non-specified direction if only one were specified.

@alejoe91
Copy link
Member

alejoe91 commented Aug 5, 2022

Thanks @D1o0g9s

I agree it should be allowed to just pass lims in one axis. Note that you can always generate an external ax and pass it to the plot_probe. Then you can set lims for x and y axis as you will ;)

@alejoe91 alejoe91 added the question Further information is requested label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants