Correct vertical advection of humidity #556
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why, at the moment, humidity is reconstructed differently from temperature and velocities when it comes to vertical advection.
This should not be the case (i.e., temperature and humidity should follow the same transport equation).
I suspect this was just a mishap given that humidity is separated by the other variables because it is active only in a wet core.
This PR corrects this "problem".
I will try some tests to make sure everything is correct before merging