Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct vertical advection of humidity #556

Closed
wants to merge 1 commit into from

Conversation

simone-silvestri
Copy link
Collaborator

I don't know why, at the moment, humidity is reconstructed differently from temperature and velocities when it comes to vertical advection.

This should not be the case (i.e., temperature and humidity should follow the same transport equation).
I suspect this was just a mishap given that humidity is separated by the other variables because it is active only in a wet core.
This PR corrects this "problem".
I will try some tests to make sure everything is correct before merging

@simone-silvestri simone-silvestri added the do not merge 🚨 This PR needs some verification label Jun 13, 2024
@milankl milankl added vertical ⬆️ Affecting the vertical dimension humidity 💧 Affecting the hydrological cycle labels Jun 13, 2024
@simone-silvestri simone-silvestri added dynamics 〰️ Affects the dynamical core and removed vertical ⬆️ Affecting the vertical dimension humidity 💧 Affecting the hydrological cycle labels Jun 13, 2024
@milankl
Copy link
Member

milankl commented Jun 17, 2024

Thanks Simone, this is only relevant for WENO advection though right? Because all others use the current time step anyway? Asking because with #555 I've moved the evaluating of all parameterizations to the previous instead of the current timestep which seems to help massively with numerical stability. It also largely makes all flux limiters we previously had redundant. Just checking in relation to the vertical advection whether it would also be important to evaluate more at the previous rather than the current time step?

@milankl
Copy link
Member

milankl commented Sep 25, 2024

superceded by #525

@milankl milankl closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge 🚨 This PR needs some verification dynamics 〰️ Affects the dynamical core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants