Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix load_trajectory #415

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Fix load_trajectory #415

merged 1 commit into from
Nov 16, 2023

Conversation

maximilian-gelbrecht
Copy link
Member

Just fixing a bug due to a change in NCDatasets

@milankl
Copy link
Member

milankl commented Nov 16, 2023

I thought we had a test for this function?

@milankl milankl added bug 🐞 Something isn't working output 📤 NetCDF or JLD2 output, their writers, formats, etc labels Nov 16, 2023
@maximilian-gelbrecht
Copy link
Member Author

We have one which tests it for the time variable. This one was also not affected, and the routine never returned an error.

Before [:] returned the dataset as an Array in its regular shape (similar to how the Python netCDF library works (from memory)). Now [:] returns it as a Vector so like indexing a regular n-d Array with [:] and Array is the correct command. The tests just have one test for returning the correct time axis from the dataset. Time is always a vector, so this yielded no error.

@maximilian-gelbrecht maximilian-gelbrecht merged commit b047723 into main Nov 16, 2023
3 checks passed
@maximilian-gelbrecht maximilian-gelbrecht deleted the load_trajectory-fix branch November 16, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working output 📤 NetCDF or JLD2 output, their writers, formats, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants