Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WaitForPageAction incorrectly returns success for PageNavigation("/") #78

Open
jonstelly opened this issue Dec 14, 2015 · 1 comment
Open

Comments

@jonstelly
Copy link
Contributor

I have a HomePage:

[PageNavigation("/")]
public class HomePage
{
}

If I try to use:

Then I wait 5 second for the Home page

It returns success, even when I'm not on that page.

If I change my HomePage to:

[PageNavigation("/Home")]
public class HomePage
{
}

Then it correctly returns an error. I'm using Selenium. I'm just starting to debug the code now to figure out where this happens, but seems like it might be UriHelper.GetQualifiedPageUriRegex() that's used in BrowserBase.CheckIsOnPage().

Does this seem like a legit bug, or is this a known issue?

@jonstelly jonstelly changed the title WaitForPageAction incorrectly returns true for PageNavigation("/") WaitForPageAction incorrectly returns success for PageNavigation("/") Dec 14, 2015
@NickMcG
Copy link
Contributor

NickMcG commented Dec 17, 2015

I have 2 pages:

[PageNavigation("/")]
public class HomePage

and

[PageNavigation("/Home/Submit")]
public class ThankYouPage

My test looks like:

Given I navigated to the home page
And <I fill in some stuff>
When I choose the submit button
And I wait for the thank you page
Then I am on the thank you page

That seems to work fine for me. I was getting flaky results before I added the "And I wait for the thank you page".

I hope that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants