Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TV shows #14

Closed
SpaceK33z opened this issue Dec 18, 2016 · 14 comments
Closed

Add support for TV shows #14

SpaceK33z opened this issue Dec 18, 2016 · 14 comments
Assignees
Labels
beta this is in testing (BETA) and requires beta-testers (active feedback) enhancement this item makes the project better in some way in-progress this item is being worked on wiki requests that can be added to the Wiki for future users

Comments

@SpaceK33z
Copy link
Owner

This extension was initially meant for Movieo, which supports only movies, but now that IMDb and Trakt.tv are supported we could support TV shows as well.

@OmgImAlexis
Copy link

OmgImAlexis commented Dec 18, 2016

If you want to add support for sickbeard, sickrage or medusa so it could actually download them all there's a decent api for it. I'm one of the developers so let me know if you need any help.

https://github.com/SickRage/SickRage
https://github.com/pymedusa/Medusa

@SpaceK33z
Copy link
Owner Author

Thanks for reaching out. For this ticket I'll first implement support for viewing TV shows from {IMDb,Trakt} in Plex, and later I'll look at implementing downloaders. I'm using Sonarr though, so I don't know if I'll ever add support for SickRage to be honest.

@OmgImAlexis
Copy link

Well if you can layout a modular system I'd be happy to add sickbeard and the two forks.

SpaceK33z added a commit that referenced this issue Dec 18, 2016
@SpaceK33z
Copy link
Owner Author

Alrighty, I'll ping you when it comes to that.

Unfortunately TV show download support is a lot harder than movies since there are seasons, and then you need to provide a UI in the website to select the season. Or maybe I could make an option in the settings page where you can select what it should download (e.g. First season, All seasons), that way I don't have to make a UI and it keeps everything simple. What do you think?

SpaceK33z added a commit that referenced this issue Dec 18, 2016
@OmgImAlexis
Copy link

Since sickbeard, sickrage and medusa all support thetvdb mapping it shouldn't be too hard to get it to download. You'd just need to provide the TVDB ID as well as the season and episode you want. It could then check if you've got it downloaded and if not then add the episode to the queue to download.

Trakt also displays the TVDB ID for most shows on the page so you can use that to get the ID.

@SpaceK33z SpaceK33z added the enhancement this item makes the project better in some way label Jan 20, 2017
@enchained
Copy link

enchained commented Jan 11, 2018

If you will support TV shows and Sonarr in the future, I would love to have support for the myshows.me website (Russian Trakt.tv alternative for TV shows). For example: https://en.myshows.me/view/5713/
Shows pages can have urls in those formats:

https://en.myshows.me/view/5713/
https://myshows.me/view/5713/
https://ua.myshows.me/view/5713/

and every show page has an IMDB link, located here:

$("div.clear>p:nth-child(9)>a")[0].href

Name:
for pages 'https://myshows.me/ *': $("p.subHeader")[0].innerText
for pages 'https://**.myshows.me/ *': $("main>h1")[0].innerText (needs to remove extra space at the end of the result)

Year (needs regex for first 4-letter number):

$("div.clear>p.flat")[0].innerText

If this data is enough for the website support, I'll try to make a pull request if/when the TV support will be added.

@SpaceK33z
Copy link
Owner Author

I don't have the time to implement TV show support in the near future unfortunately. TV shows is a lot harder than movies because you have seasons and individual episodes, and without at least supporting seasons it's kinda useless. I imagine you would have a button on TV show pages that works like adding a show to Sonarr does:

screen shot 2018-01-11 at 21 04 21

If someone wants to start working on this I will review a PR and help anyone with it though!

@Ephellon Ephellon closed this as completed Sep 5, 2018
@Ephellon Ephellon self-assigned this Jun 28, 2019
This was referenced Jun 28, 2019
@Ephellon Ephellon added the in-progress this item is being worked on label Jul 3, 2019
@Ephellon
Copy link
Collaborator

Ephellon commented Jul 3, 2019

Just leaving notes:

  • Ignore season options, just leave a pop-up that'll take the user to the page for editing (if wanted)
  • Find some sort of API documentation for SickRage

I downvoted my own comment... there's no f***ing API documentation

@Ephellon
Copy link
Collaborator

Ephellon commented Jul 7, 2019

So, got everything except "adding" to work. Will keep at it for a little while

@Ephellon Ephellon reopened this Jul 7, 2019
@Ephellon
Copy link
Collaborator

Ephellon commented Jul 9, 2019

Done

@Ephellon Ephellon closed this as completed Jul 9, 2019
@Ephellon Ephellon removed the in-progress this item is being worked on label Jul 9, 2019
@Ephellon
Copy link
Collaborator

Ephellon commented Jul 9, 2019

Will not be adding SickRage support, no patience to install another application and fumble through the API

Ephellon added a commit that referenced this issue Dec 18, 2019
* Fixed options page, theme, and saving errors. Updated UI/UX

* Fixed #127. Applied recommendations from DeepScan.

* Beta branch (#128)

* Fixed options page, theme, and saving errors. Updated UI/UX

* Fixed #127. Applied recommendations from DeepScan.

* Fixed #127. Fixed minor commentation errors (grammar).
@Ephellon Ephellon added the wiki requests that can be added to the Wiki for future users label Jan 1, 2020
@Ephellon Ephellon added beta this is in testing (BETA) and requires beta-testers (active feedback) in-progress this item is being worked on labels Feb 25, 2020
@Ephellon
Copy link
Collaborator

Ephellon commented Feb 25, 2020

Why do I do this to myself? Will add to Wiki after v4.1.3.0 goes live →

Adding a custom manager (Experimental Feature — v4.1.3.0)

Step 1: Go to "Custom Managers" under "Manager Settings"
image

Step 2: Select "+ Add Custom Manager"
image


Adding SiCKRAGE

Step 1: Add SiCKRAGE
image

Step 2: Edit/verify the Connection Settings
image

Step 3: Edit/verify the Syntaxes
image

@Ephellon Ephellon reopened this Feb 25, 2020
@Ephellon
Copy link
Collaborator

Ephellon commented Feb 25, 2020

Things to add

  • The "Import Rules" function
  • The "Manager Rules Notation" functionality

SiCKRAGE.json

{
    "SiCKRAGE": {
        "type": "show",
        "api-url": {
            "GET": "{url}home/",
            "add": { "POST": "{api-url}addShows/newShow?apikey={api}&search_string={name}" },
            "find": { "GET": "{api-url}displayShow?apikey={api}&show={tvdb}" },
            "view": { "OPEN": "{:add}" }
        }
    }
}

@Ephellon
Copy link
Collaborator

Ephellon commented Mar 3, 2020

Moved to #166

@Ephellon Ephellon closed this as completed Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta this is in testing (BETA) and requires beta-testers (active feedback) enhancement this item makes the project better in some way in-progress this item is being worked on wiki requests that can be added to the Wiki for future users
Projects
None yet
Development

No branches or pull requests

4 participants