Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG for v15 #110

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Update CHANGELOG for v15 #110

merged 1 commit into from
Apr 12, 2024

Conversation

dbrgn
Copy link
Contributor

@dbrgn dbrgn commented Apr 11, 2024

No description provided.

@dbrgn dbrgn requested a review from a team April 11, 2024 21:57
@dbrgn dbrgn self-assigned this Apr 11, 2024
rnestler
rnestler previously approved these changes Apr 12, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
s3lph
s3lph previously approved these changes Apr 12, 2024
@dbrgn
Copy link
Contributor Author

dbrgn commented Apr 12, 2024

UGH, reviews are auto-dismissed after force pushes, even when just rebasing.

I unchecked "Dismiss stale pull request approvals when new commits are pushed" in the settings and reduced the number of required approvals to 1 (we'll still use common sense before clicking merge).

@s3lph would you care to re-approve after my rebase?

@dbrgn dbrgn requested a review from s3lph April 12, 2024 22:53
@dbrgn
Copy link
Contributor Author

dbrgn commented Apr 12, 2024

Never mind, I temporarily disabled the required approvals, since we already got 2 for this PR.

@dbrgn dbrgn merged commit ab25e78 into master Apr 12, 2024
8 checks passed
@dbrgn dbrgn deleted the changelog branch April 12, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants