Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PeakDetector to make it more user-friendly #81

Open
sofian opened this issue Apr 5, 2023 · 0 comments
Open

Refactor PeakDetector to make it more user-friendly #81

sofian opened this issue Apr 5, 2023 · 0 comments
Assignees

Comments

@sofian
Copy link
Collaborator

sofian commented Apr 5, 2023

The way PeakDetector is designed makes it a bit (and unnecessarily) cumbersome and counter-intuitive. One needs to now about the normal law and outliers. Instead, we could simply be able to send a signal directly to the PeakDetector which could be in charge of detecting peaks.

Furthermore, instead of using the principle of "outliers" it would be interesting to use a concept of "sensitvity" as a percentage (%) (0..1) For this we could use the "logit" function and calculate the n-stddev from a probability.

@sofian sofian self-assigned this Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant