-
Notifications
You must be signed in to change notification settings - Fork 2
/
eslint.config.js
274 lines (265 loc) · 8.33 KB
/
eslint.config.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
'use strict'
const path = require('node:path')
const js = require('@eslint/js')
const importXPlugin = require('eslint-plugin-import-x')
const nodePlugin = require('eslint-plugin-n')
const sortDestructureKeysPlugin = require('eslint-plugin-sort-destructure-keys')
const unicornPlugin = require('eslint-plugin-unicorn')
const tsEslint = require('typescript-eslint')
const constants = require('@socketregistry/scripts/constants')
const {
PACKAGE_JSON,
gitIgnoreFile,
npmPackagesPath,
prettierIgnoreFile,
relNpmPackagesPath,
rootTsConfigPath
} = constants
const { readJsonSync } = require('@socketsecurity/registry/lib/fs')
const { flatConfigs: origImportXFlatConfigs } = importXPlugin
const conditionalConfig = (config, isEsm) => {
const files = Array.isArray(config.files)
? isEsm
? config.files.filter(p => p.startsWith(relNpmPackagesPath))
: config.files
: undefined
return files?.length
? [
{
...config,
files
}
]
: []
}
const getIgnores = isEsm =>
// Lazily access constants.npmPackageNames.
constants.npmPackageNames.flatMap(regPkgName => {
const pkgPath = path.join(npmPackagesPath, regPkgName)
const pkgJsonPath = path.join(pkgPath, PACKAGE_JSON)
const { type } = readJsonSync(pkgJsonPath)
const shouldIgnore = isEsm ? type !== 'module' : type === 'module'
const ignored = []
if (shouldIgnore) {
ignored.push(`${relNpmPackagesPath}/${regPkgName}/*`)
} else if (isEsm) {
ignored.push(`${relNpmPackagesPath}/${regPkgName}/index.js`)
} else {
ignored.push(`${relNpmPackagesPath}/${regPkgName}/*.mjs`)
}
return ignored
})
const getImportXFlatConfigs = isEsm => ({
recommended: {
...origImportXFlatConfigs.recommended,
languageOptions: {
...origImportXFlatConfigs.recommended.languageOptions,
ecmaVersion: 'latest',
sourceType: isEsm ? 'module' : 'script'
},
rules: {
...origImportXFlatConfigs.recommended.rules,
'import-x/no-named-as-default-member': 'off',
'import-x/order': [
'warn',
{
groups: [
'builtin',
'external',
'internal',
['parent', 'sibling', 'index'],
'type'
],
pathGroups: [
{
pattern: '@socket{registry,security}/**',
group: 'internal'
}
],
pathGroupsExcludedImportTypes: ['type'],
'newlines-between': 'always',
alphabetize: {
order: 'asc'
}
}
]
}
},
typescript: {
...origImportXFlatConfigs.typescript,
settings: {
...origImportXFlatConfigs.typescript.settings,
'import-x/resolver': {
'eslint-import-resolver-oxc': {
tsConfig: {
configFile: rootTsConfigPath,
references: 'auto'
}
}
}
}
}
})
function configs(sourceType) {
const isEsm = sourceType === 'module'
const ignores = getIgnores(isEsm)
const importFlatConfigs = getImportXFlatConfigs(isEsm)
return [
{
ignores,
...nodePlugin.configs['flat/recommended-script']
},
{
ignores,
...importFlatConfigs.recommended
},
{
ignores,
...importFlatConfigs.typescript
},
{
ignores,
plugins: {
'sort-destructure-keys': sortDestructureKeysPlugin,
unicorn: unicornPlugin
},
linterOptions: {
reportUnusedDisableDirectives: 'off'
},
rules: {
'n/exports-style': ['error', 'module.exports'],
// The n/no-unpublished-bin rule does does not support non-trivial glob
// patterns used in package.json "files" fields. In those cases we simplify
// the glob patterns used.
'n/no-unpublished-bin': ['error'],
'n/no-unsupported-features/es-builtins': [
'error',
{
ignores: ['Object.groupBy'],
// Lazily access constants.maintainedNodeVersions.
version: constants.maintainedNodeVersions.current
}
],
'n/no-unsupported-features/es-syntax': [
'error',
{
ignores: ['object-map-groupby'],
// Lazily access constants.maintainedNodeVersions.
version: constants.maintainedNodeVersions.current
}
],
'n/no-unsupported-features/node-builtins': [
'error',
{
ignores: [
'buffer.resolveObjectURL',
'module.enableCompileCache',
'fetch',
'fs.promises.cp'
],
// Lazily access constants.maintainedNodeVersions.
version: constants.maintainedNodeVersions.current
}
],
'n/prefer-node-protocol': ['error'],
'no-await-in-loop': ['error'],
'no-control-regex': ['error'],
'no-empty': ['error', { allowEmptyCatch: true }],
'no-new': ['error'],
'no-proto': ['error'],
'no-self-assign': ['error', { props: false }],
'no-unused-vars': [
'error',
{ argsIgnorePattern: '^_|^this$', ignoreRestSiblings: true }
],
'no-warning-comments': ['error'],
'sort-destructure-keys/sort-destructure-keys': ['error'],
'sort-imports': ['error', { ignoreDeclarationSort: true }],
'unicorn/consistent-function-scoping': ['error']
}
},
...conditionalConfig(
{
files: [`${relNpmPackagesPath}/**/*.ts`, 'test/**/*.ts'],
ignores,
languageOptions: {
ecmaVersion: 'latest',
sourceType,
parser: tsEslint.parser,
parserOptions: {
projectService: {
allowDefaultProject: [],
defaultProject: 'tsconfig.json',
tsconfigRootDir: __dirname
}
}
},
plugins: {
'@typescript-eslint': tsEslint.plugin
},
rules: {
// Define @typescript-eslint/no-extraneous-class because oxlint defines
// "no-extraneous-class": ["deny"] and trying to eslint-disable it will
// cause an eslint "Definition not found" error otherwise.
'@typescript-eslint/no-extraneous-class': ['error'],
'@typescript-eslint/no-floating-promises': ['error'],
// Define @typescript-eslint/no-misused-new because oxlint defines
// "no-misused-new": ["deny"] and trying to eslint-disable it will
// cause an eslint "Definition not found" error otherwise.
'@typescript-eslint/no-misused-new': ['error'],
'@typescript-eslint/no-misused-promises': ['error'],
// Define @typescript-eslint/no-this-alias because oxlint defines
// "no-this-alias": ["deny"] and trying to eslint-disable it will
// cause an eslint "Definition not found" error otherwise.
'@typescript-eslint/no-this-alias': ['error'],
// Returning unawaited promises in a try/catch/finally is dangerous
// (the `catch` won't catch if the promise is rejected, and the `finally`
// won't wait for the promise to resolve). Returning unawaited promises
// elsewhere is probably fine, but this lint rule doesn't have a way
// to only apply to try/catch/finally (the 'in-try-catch' option *enforces*
// not awaiting promises *outside* of try/catch/finally, which is not what
// we want), and it's nice to await before returning anyways, since you get
// a slightly more comprehensive stack trace upon promise rejection.
'@typescript-eslint/return-await': ['error', 'always']
}
},
isEsm
),
...conditionalConfig(
{
files: ['test/**/*.ts'],
ignores,
rules: {
'@typescript-eslint/no-floating-promises': 'off'
}
},
isEsm
),
...conditionalConfig(
{
files: [`${relNpmPackagesPath}/**/*.d.ts`, 'test/**/*.d.ts'],
ignores,
rules: {
'no-unused-vars': 'off'
}
},
isEsm
),
...conditionalConfig(
{
files: [`${relNpmPackagesPath}/**/*.js`, 'scripts/**/*.js'],
ignores,
rules: {
...js.configs.recommended.rules
}
},
isEsm
)
]
}
module.exports = [
gitIgnoreFile,
prettierIgnoreFile,
...configs('script'),
...configs('module')
]