From 23af2e7b255bff5217c6c94b5a53fe8dab74e1ed Mon Sep 17 00:00:00 2001 From: Lilian Saget-Lethias Date: Thu, 16 Nov 2023 17:19:11 +0100 Subject: [PATCH 1/2] feat: rollback node 16 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 7f320fd0..309095d2 100644 --- a/package.json +++ b/package.json @@ -150,7 +150,7 @@ } }, "engines": { - "node": "18" + "node": "^16" }, "devDependencies": { "@octokit/graphql": "^4.8.0", From ca49908e94a81f99d6cd95c59cec69cd1264ed3d Mon Sep 17 00:00:00 2001 From: Lilian Saget-Lethias Date: Thu, 16 Nov 2023 17:38:25 +0100 Subject: [PATCH 2/2] feat: remove custom setup-node action --- .github/actions/setup-node/action.yml | 16 ---------------- .github/workflows/branch-test-setup.yml | 12 ++++++++---- .github/workflows/e2e.yml | 12 ++++++++---- .github/workflows/quality.yml | 6 ++++-- .github/workflows/release.yml | 18 ++++++++++++------ .github/workflows/track-download-count.yml | 6 ++++-- 6 files changed, 36 insertions(+), 34 deletions(-) delete mode 100644 .github/actions/setup-node/action.yml diff --git a/.github/actions/setup-node/action.yml b/.github/actions/setup-node/action.yml deleted file mode 100644 index 15b4449a..00000000 --- a/.github/actions/setup-node/action.yml +++ /dev/null @@ -1,16 +0,0 @@ -name: Setup Node -description: Setup Node from .nvmrc - -runs: - using: composite - steps: - - name: Read Node version from .nvmrc - shell: bash - run: echo "name=NVMRC::$(cat .nvmrc)" >> $GITHUB_OUTPUT - id: nvm - - - name: Set up Node.js - uses: actions/setup-node@v2 - with: - node-version: ${{ steps.nvm.outputs.NVMRC }} - cache: yarn diff --git a/.github/workflows/branch-test-setup.yml b/.github/workflows/branch-test-setup.yml index 53e8855c..1e176582 100644 --- a/.github/workflows/branch-test-setup.yml +++ b/.github/workflows/branch-test-setup.yml @@ -26,8 +26,10 @@ jobs: - uses: actions/checkout@v3 with: fetch-depth: 0 - - name: Setup Node - uses: ./.github/actions/setup-node + - name: Set up Node.js + uses: actions/setup-node@v3 + with: + node-version-file: '.nvmrc' - name: Yarn install run: | yarn config set network-timeout 300000 @@ -88,8 +90,10 @@ jobs: - uses: actions/checkout@v3 with: fetch-depth: 0 - - name: Setup Node - uses: ./.github/actions/setup-node + - name: Set up Node.js + uses: actions/setup-node@v3 + with: + node-version-file: '.nvmrc' - name: Yarn install run: | yarn config set network-timeout 300000 diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 8a08277b..adeb4424 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -17,8 +17,10 @@ jobs: steps: - name: Checkout repository uses: actions/checkout@v3 - - name: Setup Node - uses: ./.github/actions/setup-node + - name: Set up Node.js + uses: actions/setup-node@v3 + with: + node-version-file: '.nvmrc' - name: Yarn install run: yarn --frozen-lockfile --perfer-offline @@ -57,8 +59,10 @@ jobs: os: [ubuntu-latest, windows-latest, macos-latest] steps: - uses: actions/checkout@v3 - - name: Setup Node - uses: ./.github/actions/setup-node + - name: Set up Node.js + uses: actions/setup-node@v3 + with: + node-version-file: '.nvmrc' - name: Yarn install run: | yarn config set network-timeout 300000 diff --git a/.github/workflows/quality.yml b/.github/workflows/quality.yml index fcf0a6db..3d7c789f 100644 --- a/.github/workflows/quality.yml +++ b/.github/workflows/quality.yml @@ -15,8 +15,10 @@ jobs: steps: - uses: actions/checkout@v3 - - name: Setup Node - uses: ./.github/actions/setup-node + - name: Set up Node.js + uses: actions/setup-node@v3 + with: + node-version-file: '.nvmrc' - name: Yarn install run: | yarn config set network-timeout 300000 diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index b7b052d7..17dd1f32 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -44,8 +44,10 @@ jobs: path: | ${{ env.WIN_CSC_LINK }} ${{ env.CSC_LINK }} - - name: Setup Node - uses: ./.github/actions/setup-node + - name: Set up Node.js + uses: actions/setup-node@v3 + with: + node-version-file: '.nvmrc' # >> NO Secrets - name: Temp NO_SECRETS as .env file run: | @@ -134,8 +136,10 @@ jobs: - uses: actions/checkout@v3 with: fetch-depth: 0 - - name: Setup Node - uses: ./.github/actions/setup-node + - name: Set up Node.js + uses: actions/setup-node@v3 + with: + node-version-file: '.nvmrc' - name: Yarn install run: | yarn config set network-timeout 300000 @@ -188,8 +192,10 @@ jobs: -regex ".*/bin/.*/archifiltre.*\.(exe|AppImage|dmg|msi|zip)$" -type f -exec bash -c "openssl dgst -sha512 {} > {}.sha512" \; - - name: Setup Node - uses: ./.github/actions/setup-node + - name: Set up Node.js + uses: actions/setup-node@v3 + with: + node-version-file: '.nvmrc' - name: Yarn install run: yarn --frozen-lockfile --perfer-offline - name: Import GPG key diff --git a/.github/workflows/track-download-count.yml b/.github/workflows/track-download-count.yml index d57189a7..047dfcbd 100644 --- a/.github/workflows/track-download-count.yml +++ b/.github/workflows/track-download-count.yml @@ -9,8 +9,10 @@ jobs: steps: - name: Checkout repository uses: actions/checkout@v3 - - name: Setup Node - uses: ./.github/actions/setup-node + - name: Set up Node.js + uses: actions/setup-node@v3 + with: + node-version-file: '.nvmrc' - name: Yarn install run: yarn --frozen-lockfile --perfer-offline - name: Run track