Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unidentified tables are just ignored, rather than logged as errors/warnings #221

Open
kws opened this issue Oct 6, 2023 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@kws
Copy link
Contributor

kws commented Oct 6, 2023

In “add_table_name” any unidentified tables are just ignored. This is probably right, but in most cases we would want to know that this happened

Two possible approaches:

  • Log a warning within add_table_name
  • Create a filter to catch any tables without names and log warnings for these

In fairness – both approaches are doable and perhaps a good option as it offers both a simple no-config-required approach, and a more customisable approach to provide detailed logging

@kws kws added the bug Something isn't working label Oct 6, 2023
@kws kws self-assigned this Oct 6, 2023
@kws kws moved this to Backlog in LIIA Tools / LA Data Platform Oct 6, 2023
@patrick-troy
Copy link
Contributor

Might also want to identify if there are extra columns that have been removed. I'm still uncertain if this is worth being added into the error report but it was previously in there

@patrick-troy patrick-troy assigned patrick-troy and unassigned kws Feb 5, 2024
@patrick-troy patrick-troy moved this from Backlog to In progress in LIIA Tools / LA Data Platform Feb 5, 2024
@patrick-troy patrick-troy moved this from In progress to Testing in LIIA Tools / LA Data Platform Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants