Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naiively Fix #285 #286

Closed
wants to merge 2 commits into from
Closed

Naiively Fix #285 #286

wants to merge 2 commits into from

Conversation

sisby-folk
Copy link

I've just added an updateNeighborsAt call after every setBlockAndUpdate call for retainOriginalBlocks, which seems to stop the grey grass issue.

I'll continue testing this on a custom build, but I figured you might have insight for any potential issues with this solution.

@sisby-folk
Copy link
Author

sisby-folk commented May 4, 2023

So I'm now totally unsure if this fixes the problem. There seems to be some kind of issue that might specifically relate to fabric seasons snow? I'm still getting tonnes of gray grass - even in freshly generated worlds. And sometimes I'm even getting dirt, which is even weirder.

Without fabric seasons it appears to work as expected
image

Pre 2.0, fabric seasons uses a custom kind of snow, in 2.0, it seems to use vanilla snow - causing this: lucaargolo/fabric-seasons#118 which seems related. I've seen this issue on the pre-2.0 version. The 2.0 version doesn't have it - so I'd assume it relates to the non-vanilla snow blocks.

I'll leave this up for reference, but it seems like it's on seasons to fix 2.0 enough to be usable. Not... immensely clear on whether this fix is needed without seasons, now.

@sisby-folk
Copy link
Author

Cool yeah this is total junk - works fine on 5.1.1, it's specifically a seasons pre-2.0 incompat - closed!

@sisby-folk sisby-folk closed this May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant