Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type hint #194

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Fix type hint #194

merged 3 commits into from
Oct 22, 2024

Conversation

sfc-gh-cnivera
Copy link
Collaborator

No description provided.

@sfc-gh-jsummer
Copy link
Collaborator

@sfc-gh-cnivera - I caught a couple dozen or so other scenarios of using | with None in typehints. Please review my commit. Yours looks good.

@sfc-gh-cnivera sfc-gh-cnivera merged commit 7a3afa7 into main Oct 22, 2024
2 checks passed
@sfc-gh-cnivera sfc-gh-cnivera deleted the cnivera/fix-type-hints branch October 22, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jsummer sfc-gh-jsummer sfc-gh-jsummer approved these changes

@sfc-gh-rehuang sfc-gh-rehuang Awaiting requested review from sfc-gh-rehuang sfc-gh-rehuang is a code owner

@sfc-gh-twhite sfc-gh-twhite Awaiting requested review from sfc-gh-twhite

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-cnivera @sfc-gh-jsummer