Use WeakOutput in OutputUserData, Output in WlOutputData
#1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An `Output` is just a struct containing `OutputData`, so there's no need for it to exist as a seperate type. Just use `Output`.
There is no need for this to hold a strong reference to the `Output`. Presumably `WlOutputData` is freed when the global is removed, so it is correct to hold a strong reference there.
Drakulix
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally it's best not to hold strong references like this in user data, and it's definitely important if we use
WeakOutput::is_alivefor anything (#1584). In any case, making it weak seems to be easy.This alone didn't solve the issue I was seeing in cosmic-comp (which pop-os/cosmic-comp#990 addresses, at least for now), so there may be more
Outputstrong references to deal with somewhere...