From e5e656f34fd9c2cfcfae65b0344be237b710e7ed Mon Sep 17 00:00:00 2001
From: yairm210 <yairm210@hotmail.com>
Date: Wed, 1 Jan 2025 14:32:26 +0200
Subject: [PATCH] perf: Convert tile percentage categories to EnumMap for both
 speed and memory

---
 .../unciv/logic/map/tile/TileStatFunctions.kt | 26 ++++++++++++-------
 1 file changed, 17 insertions(+), 9 deletions(-)

diff --git a/core/src/com/unciv/logic/map/tile/TileStatFunctions.kt b/core/src/com/unciv/logic/map/tile/TileStatFunctions.kt
index c200c3555d20a..a74fce64dd34b 100644
--- a/core/src/com/unciv/logic/map/tile/TileStatFunctions.kt
+++ b/core/src/com/unciv/logic/map/tile/TileStatFunctions.kt
@@ -11,6 +11,7 @@ import com.unciv.models.ruleset.unique.UniqueType
 import com.unciv.models.stats.Stat
 import com.unciv.models.stats.Stats
 import com.unciv.ui.components.extensions.toPercent
+import java.util.EnumMap
 
 fun List<Pair<String, Stats>>.toStats(): Stats {
     val stats = Stats()
@@ -39,9 +40,9 @@ class TileStatFunctions(val tile: Tile) {
         val percentageStats = getTilePercentageStats(observingCiv, city, localUniqueCache)
         for (stats in statsBreakdown) {
             val tileType = when (stats.first) {
-                improvement -> "Improvement"
-                road.name -> "Road"
-                else -> "Terrain"
+                improvement -> TilePercentageCategory.Improvement
+                road.name -> TilePercentageCategory.Road
+                else -> TilePercentageCategory.Terrain
             }
             for ((stat, value) in percentageStats[tileType]!!)
                 stats.second[stat] *= value.toPercent()
@@ -170,10 +171,16 @@ class TileStatFunctions(val tile: Tile) {
         }
         return list
     }
+    
+    enum class TilePercentageCategory{
+        Terrain,
+        Improvement,
+        Road
+    }
 
     // Only gets the tile percentage bonus, not the improvement percentage bonus
     @Suppress("MemberVisibilityCanBePrivate")
-    fun getTilePercentageStats(observingCiv: Civilization?, city: City?, uniqueCache: LocalUniqueCache): HashMap<String, Stats> {
+    fun getTilePercentageStats(observingCiv: Civilization?, city: City?, uniqueCache: LocalUniqueCache): EnumMap<TilePercentageCategory, Stats> {
         val terrainStats = Stats()
         val stateForConditionals = StateForConditionals(civInfo = observingCiv, city = city, tile = tile)
 
@@ -221,11 +228,12 @@ class TileStatFunctions(val tile: Tile) {
                     addStats(unique.params[1], stat, unique.params[0].toFloat())
             }
         }
-        return hashMapOf(
-            Pair("Terrain", terrainStats),
-            Pair("Improvement",improvementStats),
-            Pair("Road", roadStats),
-        )
+        
+        return EnumMap<TilePercentageCategory, Stats>(TilePercentageCategory::class.java).apply {
+            put(TilePercentageCategory.Terrain, terrainStats)
+            put(TilePercentageCategory.Improvement, improvementStats)
+            put(TilePercentageCategory.Road, roadStats)
+        }
     }
 
     fun getTileStartScore(cityCenterMinStats: Stats): Float {