Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use username/password authentication to test IBM MQ in the integration tests #3

Merged

Conversation

florenzen
Copy link

@florenzen florenzen commented Dec 20, 2023

Description

The commit ibm-messaging/mq-container@a8ff0a5 changed the handling of passwords for the developer configuration. Therefore, it is necessary to explicitly set them in the container environment and for the client properties.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

It fixes the integration tests.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

…n tests

The commit ibm-messaging/mq-container@a8ff0a5 changed the handlin gof passwords for the developer configuration. Therefore, it is necessary to explicitly set them in the container environment and for the client properties.

Signed-off-by: Florian Lorenzen <[email protected]>
Copy link
Collaborator

@theodore-evans theodore-evans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theodore-evans theodore-evans merged commit 9f53dd5 into main Dec 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants