Damage taken every 10-20 seconds while in sealed room

[Lennywasafish]

Description (Required)

I created a small base in the earth's orbit in an enclosed space with iron blocks and glass. I have oxygen sealers and space heaters to stop damage which works for the most part, but every 10 seconds or so, I still seem to take damage. Every 4-5 hits of damage is freezing damage

Steps to reproduce the Issue (Required)

I have done everything including trying every type of block, making it a smaller space, removing windows, and removing automatic doors and it still consistently happens.

Expected behavior (Required)

I would take no damage

Server Log / Error Report

N/A

Environment (Required)

• Minecraft Version: Paper - 259 1.17.1
• Slimefun Version: DEV - 968
• Plugin Version: DEV - 5

[Seggan]

try checking with /gf sealed <number>. find the lowest highest number that says "not sealed"

[Seggan]

correction: i meant highest. consider anything above 10000 as that your base is not fully sealed

[Lennywasafish]

I ran the command and it returned /gf sealed 1000000 and it returned Sealed 1.554 ms. I am still taking damage every 10 or so seconds though

[Seggan]

Find the highest number that says "Not sealed". This is very important for this issue

[Lennywasafish]

Find the highest number that says "Not sealed". This is very important for this issue

Regardless of the number I put in, it always gives the output of sealed. I have tried up to 1e9 before it gives me an internal error

[Seggan]

Try going down. i.e. 1000 or 5000

[Seggan]

Start from 100 then work your way up to 100000

[Lennywasafish]

Start from 100 then work your way up to 100000

1-1572 gives the output of not sealed but anything above that gives sealed

[Seggan]

Hmm

[Lennywasafish]

Hmm

updated reply with exact numbers

[Seggan]

What do your Space Heaters say? And whats the report of /gf effects?

[Lennywasafish]

What do your Space Heaters say?

operational

[Seggan]

Edited

[Lennywasafish]

I get no output

[Lennywasafish]

As stated in my original report, I take damage from lack of oxygen the first 5 times, then I take freezing damage

[Seggan]

Yes, ik, I was trying to diagnose further

[Lennywasafish]

If you'd like, I can add you on discord and dm you the ip to my server and you can test for yourself

[Seggan]

Strange that other have not reported it yet

[Lennywasafish]

Yeah it seems like a problem specific to me

[Seggan]

If you'd like, I can add you on discord and dm you the ip to my server and you can test for yourself

I can't unfortunately, my MC acc is being used rn

[Lennywasafish]

Ok no worries

[Lennywasafish]

I can send a screen recording if you'd like

[Seggan]

Sure

[Lennywasafish]

https://imgur.com/LurrPYy

[Seggan]

Super fans work only horizontally and diagonally (on the x/z axis)

[Seggan]

Try moving them

[Lennywasafish]

I've placed them everywhere, no difference, the problem also persists in a 5x5 room without superfans so that isn't the issue

[Seggan]

This is very strange

[Seggan]

Also take note of #69 perhaps that is the problem?

[Lennywasafish]

Yeah I made that issue too, that only applies to trapdoors that are on the bottom side of the block

[Lennywasafish]

And it happens while standing on iron blocks too

[Seggan]

I don't know how to resolve this, I do not know what is causing it. Sorry.

[Lennywasafish]

Ok, thanks for trying

[orangeowie4]

this happens to me too sometimes

[char3210]

Can you add me on discord? (Char#5513) Maybe I'll give this issue a tackle

[Seggan]

Join the Slimefun Addon Community Discord: https://discord.gg/SqD3gg5SAU

[Modog500000]

Ok, thanks for trying

Wait did you have ion dispensers?

[Ironnoob73]

I have the same problem.

[Seggan]

No errors?

[vojtaBerry2]

Strange that other have not reported it yet

i have the same problem

[Seggan]

Please send me any errors and the output of /gf effects

[JTechGaming]

i have same problems

[JTechGaming]

https://youtu.be/GWwV8FELXTM

[Derbosik]

Same issue here

[GallowsDove]

The only reason I can think of why this is happening is that in ProtectingBlock

private void uniqueTick() {
    //noinspection deprecation
    Galactifun.protectionManager().clearProtectedBlocks();
    for (BlockPosition l : new HashSet<>(allBlocks)) {
        updateProtections(l);
    }
}

The protection blocks are cleared first and only then are they calculated and readded. There can be a brief window where the protection isn't added yet, but on another thread, it can be checked whether that protection exists, thus creating a race condition.
A possible fix could be to calculate all the protections before clearing them and just replace the old ones with the new ones.

I'm not sure about this tho, so let me know what you think

[Seggan]

That's what I was thinking, but the ticker is synchronised