Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracting Quick Segmentation Mode into separate class for reusability reasons #115

Closed
che85 opened this issue Feb 29, 2016 · 5 comments · Fixed by #224
Closed

Extracting Quick Segmentation Mode into separate class for reusability reasons #115

che85 opened this issue Feb 29, 2016 · 5 comments · Fixed by #224
Assignees

Comments

@che85
Copy link
Member

che85 commented Feb 29, 2016

In order to use the Quick Segmentation Mode (Volume Clip) also in other modules like mpReview (issue SlicerProstate/mpReview#93) we should extract a class which could be used by other modules as well...

@che85 che85 self-assigned this Feb 29, 2016
@che85
Copy link
Member Author

che85 commented Apr 12, 2016

@fedorov: Maybe we should provide a module for that, where we have all those buttons including undo/redo?

@fedorov
Copy link
Member

fedorov commented Apr 12, 2016

We should coordinate with @lassoan and @cpinter. There is work on the next generation of Editor, and there is a plan to integrate VolumeClip there. We should not do something that will have to be redone anyway very soon.

@fedorov
Copy link
Member

fedorov commented Apr 12, 2016

Correction: I meant to say, maybe there is a plan to integrate VolumeClip there.

@che85
Copy link
Member Author

che85 commented Apr 12, 2016

Yeah makes sense

@cpinter
Copy link

cpinter commented Apr 13, 2016

Indeed, it is in the plans to integrate as many segmentation tools into the new SegmentEditor as possible, including VolumeClip.
Although we "released" SegmentEditor in SlicerRT, i.e. if you install SlicerRT then you can access it and all its functions, we're still in the process of stabilizing/optimizing it, and we're not going to add any additional tools before integrating it into Slicer core, hopefully around the summer project week. The reason is that first everyone needs to be convinced that it can do everything Editor can, before we put in additional features (there are a few already, but those are implicit, coming with the design).
If we can manage that before the project week, then we can potentially work on adding the most demanded effect in Heidelberg. If this is more urgent, then contributions are welcome, and we'd be happy to provide guidance!

che85 added a commit to che85/SliceTracker that referenced this issue Oct 4, 2016
…erProstate#115)

TODO: remove code from SliceTracker and adapt to new module
che85 added a commit to che85/SliceTracker that referenced this issue Oct 5, 2016
…rostate#115)

- removed old code
- centering labels after segmentation
che85 added a commit to che85/SliceTracker that referenced this issue Oct 8, 2016
…erProstate#115)

TODO: remove code from SliceTracker and adapt to new module
che85 added a commit to che85/SliceTracker that referenced this issue Oct 8, 2016
…rostate#115)

- removed old code
- centering labels after segmentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants