Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration #1

Open
MSevey opened this issue Mar 22, 2021 · 0 comments
Open

Add configuration #1

MSevey opened this issue Mar 22, 2021 · 0 comments

Comments

@MSevey
Copy link
Contributor

MSevey commented Mar 22, 2021

Issue by m-cat
Friday Aug 21, 2020 at 15:11 GMT
Originally opened as NebulousLabs/skynet-cli#7


Entering the same options e.g. --api-key every time can be tedious. There should be configuration options such as a dot-file and/or environment variables. Some initial thoughts:

  1. As part of Smart portal selection NebulousLabs/skynet-docs#21 we should support system-wide configuration files with not just default portal selection but also connection options like --api-key etc.
  2. We should also support environment variables as they are standard fare for cli applications. They should be namespaced with SKYNET_ e.g. SKYNET_API_KEY.
  3. The priority of configuration should be as given here, that is, check first for cli options, then env vars, then config options.

Note: it is actually preferable to outsource these configuration responsibilities to the Go SDK itself. Every call from the CLI to the Go SDK will initiate a new client which should initialize the appropriate values based on the configs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant